From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: [Qemu-devel] [PATCH 0/9] tests: apci: consolidate and cleanup ACPI test code
Date: Mon, 10 Dec 2018 19:10:06 +0100 [thread overview]
Message-ID: <1544465415-207855-1-git-send-email-imammedo@redhat.com> (raw)
While working on adding tests for virt/arm board (uefi/XSDT/64-bit table pointers),
I found it's rather difficult to deal with mixed ACPI testing code that we've
collected so far. So instead of just adding a pile of XSDT hacks on top, here
goes small refactoring series:
* that removes dead code
* replaces reading tables with a fetch per table everywhere instead of
mix of field by field and whole table
* consolidates the way tables are read (reduces code duplication)
* test no longer depends on ACPI structures from QEMU (i.e. doesn't affected
by mistakes there)
* fixiex FACS not beint compared against reference tables
Overall test is reduced on ~170LOC and hopefully it makes easier to add more
stuff on top.
PS:
Series depends on '[PATCH v3 0/8] hw: acpi: RSDP fixes and refactoring'
to avoid nontrivial conflicts
PS2:
arm/virt test patches fill follow up a separate series on top of this one
for not to mix things up
CC: "Michael S. Tsirkin" <mst@redhat.com>
CC: Thomas Huth <thuth@redhat.com>
CC: Laurent Vivier <lvivier@redhat.com>
CC: Samuel Ortiz <sameo@linux.intel.com>
Igor Mammedov (9):
tests: acpi: remove not used ACPI_READ_GENERIC_ADDRESS macro
tests: acpi: use AcpiSdtTable::aml in consistent way
tests: acpi: make sure FADT is fetched only once
tests: acpi: simplify rsdt handling
tests: acpi: reuse fetch_table() for fetching FACS and DSDT
tests: acpi: reuse fetch_table() in vmgenid-test
tests: smbios: fetch whole table in one step instead of reading it
step by step
tests: acpi: squash sanitize_fadt_ptrs() into test_acpi_fadt_table()
tests: acpi: use AcpiSdtTable::aml instead of
AcpiSdtTable::header::signature
tests/acpi-utils.h | 51 ++--------
tests/acpi-utils.c | 33 ++++--
tests/bios-tables-test.c | 257 ++++++++++++-----------------------------------
tests/vmgenid-test.c | 63 ++++--------
4 files changed, 116 insertions(+), 288 deletions(-)
--
2.7.4
next reply other threads:[~2018-12-10 18:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 18:10 Igor Mammedov [this message]
2018-12-10 18:10 ` [Qemu-devel] [PATCH 1/9] tests: acpi: remove not used ACPI_READ_GENERIC_ADDRESS macro Igor Mammedov
2018-12-10 18:26 ` Philippe Mathieu-Daudé
2018-12-10 18:10 ` [Qemu-devel] [PATCH 2/9] tests: acpi: use AcpiSdtTable::aml in consistent way Igor Mammedov
2018-12-19 19:02 ` Wainer dos Santos Moschetta
2018-12-20 12:09 ` Igor Mammedov
2018-12-10 18:10 ` [Qemu-devel] [PATCH 3/9] tests: acpi: make sure FADT is fetched only once Igor Mammedov
2018-12-10 18:10 ` [Qemu-devel] [PATCH 4/9] tests: acpi: simplify rsdt handling Igor Mammedov
2018-12-10 18:10 ` [Qemu-devel] [PATCH 5/9] tests: acpi: reuse fetch_table() for fetching FACS and DSDT Igor Mammedov
2018-12-10 18:10 ` [Qemu-devel] [PATCH 6/9] tests: acpi: reuse fetch_table() in vmgenid-test Igor Mammedov
2018-12-10 18:10 ` [Qemu-devel] [PATCH 7/9] tests: smbios: fetch whole table in one step instead of reading it step by step Igor Mammedov
2018-12-10 18:10 ` [Qemu-devel] [PATCH 8/9] tests: acpi: squash sanitize_fadt_ptrs() into test_acpi_fadt_table() Igor Mammedov
2018-12-10 18:10 ` [Qemu-devel] [PATCH 9/9] tests: acpi: use AcpiSdtTable::aml instead of AcpiSdtTable::header::signature Igor Mammedov
2018-12-19 16:38 ` [Qemu-devel] [PATCH 0/9] tests: apci: consolidate and cleanup ACPI test code Michael S. Tsirkin
2018-12-19 16:45 ` Daniel P. Berrangé
2018-12-19 16:56 ` Michael S. Tsirkin
2018-12-20 12:14 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544465415-207855-1-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sameo@linux.intel.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).