From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWQAk-0001VD-Bx for qemu-devel@nongnu.org; Mon, 10 Dec 2018 13:20:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWQAh-0006Lo-3o for qemu-devel@nongnu.org; Mon, 10 Dec 2018 13:20:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43034) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gWQAd-0006Jl-K9 for qemu-devel@nongnu.org; Mon, 10 Dec 2018 13:20:45 -0500 From: Igor Mammedov Date: Mon, 10 Dec 2018 19:10:06 +0100 Message-Id: <1544465415-207855-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH 0/9] tests: apci: consolidate and cleanup ACPI test code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Thomas Huth , Laurent Vivier , Samuel Ortiz While working on adding tests for virt/arm board (uefi/XSDT/64-bit table pointers), I found it's rather difficult to deal with mixed ACPI testing code that we've collected so far. So instead of just adding a pile of XSDT hacks on top, here goes small refactoring series: * that removes dead code * replaces reading tables with a fetch per table everywhere instead of mix of field by field and whole table * consolidates the way tables are read (reduces code duplication) * test no longer depends on ACPI structures from QEMU (i.e. doesn't affected by mistakes there) * fixiex FACS not beint compared against reference tables Overall test is reduced on ~170LOC and hopefully it makes easier to add more stuff on top. PS: Series depends on '[PATCH v3 0/8] hw: acpi: RSDP fixes and refactoring' to avoid nontrivial conflicts PS2: arm/virt test patches fill follow up a separate series on top of this one for not to mix things up CC: "Michael S. Tsirkin" CC: Thomas Huth CC: Laurent Vivier CC: Samuel Ortiz Igor Mammedov (9): tests: acpi: remove not used ACPI_READ_GENERIC_ADDRESS macro tests: acpi: use AcpiSdtTable::aml in consistent way tests: acpi: make sure FADT is fetched only once tests: acpi: simplify rsdt handling tests: acpi: reuse fetch_table() for fetching FACS and DSDT tests: acpi: reuse fetch_table() in vmgenid-test tests: smbios: fetch whole table in one step instead of reading it step by step tests: acpi: squash sanitize_fadt_ptrs() into test_acpi_fadt_table() tests: acpi: use AcpiSdtTable::aml instead of AcpiSdtTable::header::signature tests/acpi-utils.h | 51 ++-------- tests/acpi-utils.c | 33 ++++-- tests/bios-tables-test.c | 257 ++++++++++++----------------------------------- tests/vmgenid-test.c | 63 ++++-------- 4 files changed, 116 insertions(+), 288 deletions(-) -- 2.7.4