qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: G 3 <programmingkidx@gmail.com>
Cc: Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'
Date: Tue, 22 Nov 2016 01:49:37 -0500 (EST)	[thread overview]
Message-ID: <1544471039.1052299.1479797377342.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <62F97615-8739-43D4-B09C-1C34091C54D7@gmail.com>


> On Nov 21, 2016, at 3:46 PM, Eric Blake wrote:
> > On 11/21/2016 02:36 PM, Eric Blake wrote:
> > > but I'd argue that using qobject_from_jsonf() is already less-than-
> > > useful.
> >
> > In fact, we are down to only a handful of users of our modified
> > 'jsonf'
> > format (that is, strings that mix JSON with % modifiers):
> >
> > hw/pci/pcie_aer.c: build a 5-element QDict
> > monitor.c: build a 1-element QDict which contains a 2-element QDict
> > qapi/qmp-dispatch.c: build a 2-element QDict
> > qapi/qmp-event.c: Build a 2-element QDict
> >
> > plus the testsuite (check-qjson.c).
> > I'm severely tempted to just rip out all of the poorly-
> > underdocumented % parsing from the JSON parser,

Go ahead.  In fact, at least pci_aer.c should either use a QAPI type
(and it doesn't only because the error injection command is
HMP-only) or can just use a C struct.  The others are mostly
internal details and can build the QDict manual.

Paolo

  reply	other threads:[~2016-11-22  6:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21  6:30 [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL' G 3
2016-11-21  9:13 ` Markus Armbruster
2016-11-21 10:02 ` Paolo Bonzini
2016-11-21 20:12   ` G 3
2016-11-21 20:36     ` Eric Blake
2016-11-21 20:46       ` Eric Blake
2016-11-21 20:53         ` G 3
2016-11-22  6:49           ` Paolo Bonzini [this message]
2016-11-22 10:06         ` Markus Armbruster
2016-11-22 12:41           ` Eric Blake
2016-11-22 12:54             ` Paolo Bonzini
2016-11-22 15:05               ` Markus Armbruster
2016-11-22 15:02             ` G 3
2016-11-22 15:13               ` Eric Blake
2016-11-22 16:00                 ` [Qemu-devel] check-qjson failure G 3
2016-11-22 22:42                   ` Eric Blake
2016-11-22 22:22       ` [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL' G 3
2016-11-22 22:41         ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1544471039.1052299.1479797377342.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).