From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>
Subject: [Qemu-devel] [PULL 33/54] configure: Add a test for the minimum compiler version
Date: Wed, 12 Dec 2018 16:22:54 +0100 [thread overview]
Message-ID: <1544628195-37728-34-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1544628195-37728-1-git-send-email-pbonzini@redhat.com>
From: Thomas Huth <thuth@redhat.com>
So far we only had implicit requirements for the minimum compiler version,
e.g. we require at least GCC 4.1 for the support of atomics. However,
such old compiler versions are not tested anymore by the developers, so
they are not really supported anymore. Since we recently declared explicitly
what platforms we intend to support, we can also get more explicit on the
compiler version now. The supported distributions use the following version
of GCC:
RHEL-7: 4.8.5
Debian (Stretch): 6.3.0
Debian (Jessie): 4.8.4
OpenBSD (ports): 4.9.4
FreeBSD (ports): 8.2.0
OpenSUSE Leap 15: 7.3.1
Ubuntu (Xenial): 5.3.1
macOS (Homebrew): 8.2.0
So we can safely assume GCC 4.8 these days. For Clang, the situation is
a little bit more ambiguous, since it is sometimes not available in the
main distros but rather third party repositories. At least Debian Jessie
uses version 3.5, and EPEL7 for RHEL7 uses 3.4, so let's use 3.4 as
minimum Clang version now - we still can adjust this later if necessary.
Unfortunately Apple uses different version numbers for the Clang that is
included in their Xcode suite, so we need to check the version numbers
for Xcode separately. Xcode 5.1 seems to be the first one that has been
shipped with LLVM 3.4, so use this version as the minimum there.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <1543937577-28256-2-git-send-email-thuth@redhat.com>
---
configure | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/configure b/configure
index 8c292ef..51150b1 100755
--- a/configure
+++ b/configure
@@ -1837,6 +1837,31 @@ if test "$bogus_os" = "yes"; then
error_exit "Unrecognized host OS (uname -s reports '$(uname -s)')"
fi
+# Check whether the compiler matches our minimum requirements:
+cat > $TMPC << EOF
+#if defined(__clang_major__) && defined(__clang_minor__)
+# ifdef __apple_build_version__
+# if __clang_major__ < 5 || (__clang_major__ == 5 && __clang_minor__ < 1)
+# error You need at least XCode Clang v5.1 to compile QEMU
+# endif
+# else
+# if __clang_major__ < 3 || (__clang_major__ == 3 && __clang_minor__ < 4)
+# error You need at least Clang v3.4 to compile QEMU
+# endif
+# endif
+#elif defined(__GNUC__) && defined(__GNUC_MINOR__)
+# if __GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ < 8)
+# error You need at least GCC v4.8 to compile QEMU
+# endif
+#else
+# error You either need GCC or Clang to compiler QEMU
+#endif
+int main (void) { return 0; }
+EOF
+if ! compile_prog "" "" ; then
+ error_exit "You need at least GCC v4.8 or Clang v3.4 (or XCode Clang v5.1)"
+fi
+
gcc_flags="-Wold-style-declaration -Wold-style-definition -Wtype-limits"
gcc_flags="-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers $gcc_flags"
gcc_flags="-Wno-missing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"
--
1.8.3.1
next prev parent reply other threads:[~2018-12-12 15:24 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 15:22 [Qemu-devel] [PULL 00/54] Misc patches for 2018-12-12 Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 01/54] accel: Improve selection of the default accelerator Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 02/54] vhost-user-bridge: fix "unknown type name" compilation error Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 03/54] checkpatch: fix premature exit when no input or --mailback Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 04/54] checkpatch: check Signed-off-by in --mailback mode Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 05/54] checkpatch: improve handling of multiple patches or files Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 06/54] checkpatch: colorize output to terminal Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 07/54] pam: wrap MemoryRegion initialization in a transaction Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 08/54] memory: extract flat_range_coalesced_io_{del, add} Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 09/54] memory: avoid unnecessary coalesced_io_del operations Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 10/54] memory: update coalesced_range on transaction_commit Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 11/54] hax: Support for Linux hosts Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 12/54] block/iscsi: drop unused IscsiAIOCB->buf field Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 13/54] block/iscsi: take iscsilun->mutex in iscsi_timed_check_events() Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 14/54] block/iscsi: fix ioctl cancel use-after-free Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 15/54] block/iscsi: cancel libiscsi task when ABORT TASK TMF completes Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 16/54] esp-pci: Fix status register write erase control Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 17/54] scsi: esp: Defer command completion until previous interrupts have been handled Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 18/54] build-sys: don't include windows.h, osdep.h does it Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 19/54] build-sys: move windows defines in osdep.h header Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 20/54] build-sys: build with Vista API by default Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 21/54] RFC: qga: drop < Vista compatibility Paolo Bonzini
2018-12-12 15:37 ` Daniel P. Berrangé
2018-12-12 15:22 ` [Qemu-devel] [PULL 22/54] test: execute g_test_run when tests are skipped Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 23/54] test: replace gtester with a TAP driver Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 24/54] compiler.h: Add an explicit check for the compiler version Paolo Bonzini
2018-12-12 15:59 ` Thomas Huth
2018-12-12 15:22 ` [Qemu-devel] [PULL 25/54] qemu/queue.h: do not access tqe_prev directly Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 26/54] vfio: make vfio_address_spaces static Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 27/54] qemu/queue.h: leave head structs anonymous unless necessary Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 28/54] qemu/queue.h: typedef QTAILQ heads Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 29/54] qemu/queue.h: remove Q_TAILQ_{HEAD, ENTRY} Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 30/54] qemu/queue.h: reimplement QTAILQ without pointer-to-pointers Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 31/54] qemu/queue.h: simplify reverse access to QTAILQ Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 32/54] checkpatch: warn about qemu/queue.h head structs that are not typedef-ed Paolo Bonzini
2018-12-12 15:22 ` Paolo Bonzini [this message]
2018-12-12 15:22 ` [Qemu-devel] [PULL 34/54] configure: Remove obsolete check for Clang < 3.2 Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 35/54] configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012] Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 36/54] tcg/tcg.h: Remove GCC check for tcg_debug_assert() macro Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 37/54] audio/alsaaudio: Remove compiler check around pragma Paolo Bonzini
2018-12-12 15:22 ` [Qemu-devel] [PULL 38/54] includes: Replace QEMU_GNUC_PREREQ with "__has_builtin || !defined(__clang__)" Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 39/54] Remove QEMU_ARTIFICIAL macro Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 40/54] hw/watchdog/wdt_i6300esb : remove a unnecessary comment Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 41/54] vhost-net: move stubs to a separate file Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 42/54] vhost-net-user: add stubs for when no virtio-net device is present Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 43/54] vhost: restrict Linux dependency to kernel vhost Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 44/54] vhost-net: compile it on all targets that have virtio-net Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 45/54] vhost-net: revamp configure logic Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 46/54] vhost-user-test: use g_cond_broadcast Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 47/54] vhost-user-test: signal data_cond when s->rings changes Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 48/54] vhost-user: support cross-endian vnet headers Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 49/54] vhost-user-test: support VHOST_USER_PROTOCOL_F_CROSS_ENDIAN Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 50/54] vhost-user-test: skip if there is no memory at address 0 Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 51/54] vhost-user-test: reduce usage of global_qtest Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 52/54] vhost-user-test: create a main loop per TestServer Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 53/54] vhost-user-test: small changes to init_hugepagefs Paolo Bonzini
2018-12-12 15:23 ` [Qemu-devel] [PULL 54/54] vhost-user-test: create a temporary directory per TestServer Paolo Bonzini
2018-12-12 16:16 ` [Qemu-devel] [PULL 00/54] Misc patches for 2018-12-12 Eric Blake
2018-12-12 19:02 ` Thomas Huth
2018-12-12 21:11 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544628195-37728-34-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).