qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Jünger, Lukas" <lukas.juenger@rwth-aachen.de>
To: "peter.maydell@linaro.org" <peter.maydell@linaro.org>
Cc: "eric.auger@redhat.com" <eric.auger@redhat.com>,
	"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-arm] Warning when DTB memory nodes are noped
Date: Thu, 13 Dec 2018 15:00:57 +0000	[thread overview]
Message-ID: <1544713257.4811.32.camel@rwth-aachen.de> (raw)
In-Reply-To: <CAFEAcA-p-LC2swC8-AQt60QBhQN=PNJvBjbGXrtdvvvDd-74QA@mail.gmail.com>

On Thu, 2018-12-13 at 14:49 +0000, Peter Maydell wrote:
> On Thu, 13 Dec 2018 at 14:42, Jünger, Lukas
> <lukas.juenger@rwth-aachen.de> wrote:
> > 
> > Hi all,
> > 
> > If I understand correctly, all memory nodes contained in a DTB
> > passed
> > via the -dtb option are noped in hw/arm/boot.c:556-568.
> > I did not expect this to happen and only figured it out by
> > debugging
> > the kernel.
> > Do you think a warning should be issued if a DTB contains memory
> > regions that are noped?
> 
> No, because generally we expect that to happen: the DTB will
> have a memory node for whatever the stock amount of RAM on the
> target board is, but we want to delete that so we can replace
> it with a memory node saying that the system has however much
> RAM the user asked for on the command line.
> 
> Was the deletion of the memory node actually wrong in your case?
> If so we should look at fixing the wrong behaviour, rather than
> just being noisier about what we're doing...
> 
> thanks
> -- PMM

I see. In my case I wanted to specify the memory using the DTB that I
passed using the -dtb option. I had two memory ranges in the dtb and
they didn't show up in the kernel later on because they were noped by
QEMU. I found it confusing that QEMU makes changes to the DTB that I
passed via -dtb. 

Thanks,
Lukas

  reply	other threads:[~2018-12-13 15:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1544708743.4811.30.camel@rwth-aachen.de>
2018-12-13 14:49 ` [Qemu-devel] [Qemu-arm] Warning when DTB memory nodes are noped Peter Maydell
2018-12-13 15:00   ` Jünger, Lukas [this message]
2018-12-13 15:11     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1544713257.4811.32.camel@rwth-aachen.de \
    --to=lukas.juenger@rwth-aachen.de \
    --cc=eric.auger@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).