From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <lvivier@redhat.com>
Subject: [Qemu-devel] [PULL 05/13] tests/pvpanic: Make the pvpanic test independent of global_qtest
Date: Mon, 17 Dec 2018 17:21:22 +0100 [thread overview]
Message-ID: <1545063690-10116-6-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1545063690-10116-1-git-send-email-thuth@redhat.com>
We want to get rid of global_qtest in the long run, thus do not
use the wrappers like inb() and outb() here anymore.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/pvpanic-test.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/tests/pvpanic-test.c b/tests/pvpanic-test.c
index 7461a72..ff9176a 100644
--- a/tests/pvpanic-test.c
+++ b/tests/pvpanic-test.c
@@ -15,13 +15,16 @@ static void test_panic(void)
{
uint8_t val;
QDict *response, *data;
+ QTestState *qts;
- val = inb(0x505);
+ qts = qtest_init("-device pvpanic");
+
+ val = qtest_inb(qts, 0x505);
g_assert_cmpuint(val, ==, 1);
- outb(0x505, 0x1);
+ qtest_outb(qts, 0x505, 0x1);
- response = qmp_receive();
+ response = qtest_qmp_receive(qts);
g_assert(qdict_haskey(response, "event"));
g_assert_cmpstr(qdict_get_str(response, "event"), ==, "GUEST_PANICKED");
g_assert(qdict_haskey(response, "data"));
@@ -29,6 +32,8 @@ static void test_panic(void)
g_assert(qdict_haskey(data, "action"));
g_assert_cmpstr(qdict_get_str(data, "action"), ==, "pause");
qobject_unref(response);
+
+ qtest_quit(qts);
}
int main(int argc, char **argv)
@@ -38,10 +43,7 @@ int main(int argc, char **argv)
g_test_init(&argc, &argv, NULL);
qtest_add_func("/pvpanic/panic", test_panic);
- qtest_start("-device pvpanic");
ret = g_test_run();
- qtest_end();
-
return ret;
}
--
1.8.3.1
next prev parent reply other threads:[~2018-12-17 16:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 16:21 [Qemu-devel] [PULL 00/13] qtest patches Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 01/13] tests/libqos/pci: Make PCI access functions independent of global_qtest Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 02/13] ivshmem-test: Drop dependence on global_qtest Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 03/13] tests/acpi-utils: " Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 04/13] tests/vmgenid: Make test independent of global_qtest Thomas Huth
2018-12-17 16:21 ` Thomas Huth [this message]
2018-12-17 16:21 ` [Qemu-devel] [PULL 06/13] tests/boot-serial: Get rid of global_qtest variable Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 07/13] tests/test-filter: Make tests independent of global_qtest Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 08/13] tests/machine-none: Make test " Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 09/13] tests/prom-env: " Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 10/13] tests/pxe: " Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 11/13] tests: Exit boot-serial-test loop if child dies Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 12/13] tests: acpi: remove not used ACPI_READ_GENERIC_ADDRESS macro Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 13/13] tests/bios-tables-test: Sanitize test verbose output Thomas Huth
2018-12-18 17:21 ` [Qemu-devel] [PULL 00/13] qtest patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545063690-10116-6-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).