From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <lvivier@redhat.com>
Subject: [Qemu-devel] [PULL 08/13] tests/machine-none: Make test independent of global_qtest
Date: Mon, 17 Dec 2018 17:21:25 +0100 [thread overview]
Message-ID: <1545063690-10116-9-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1545063690-10116-1-git-send-email-thuth@redhat.com>
Apart from using qmp() in one spot, this test does not have any
dependencies to the global_qtest variable, so we can simply get
rid of it here by replacing the qmp() with qtest_qmp().
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/machine-none-test.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/machine-none-test.c b/tests/machine-none-test.c
index 2b3b750..4c6d470 100644
--- a/tests/machine-none-test.c
+++ b/tests/machine-none-test.c
@@ -75,6 +75,7 @@ static void test_machine_cpu_cli(void)
QDict *response;
const char *arch = qtest_get_arch();
const char *cpu_model = get_cpu_model_by_arch(arch);
+ QTestState *qts;
if (!cpu_model) {
if (!(!strcmp(arch, "microblaze") || !strcmp(arch, "microblazeel"))) {
@@ -83,13 +84,13 @@ static void test_machine_cpu_cli(void)
}
return; /* TODO: die here to force all targets have a test */
}
- global_qtest = qtest_initf("-machine none -cpu '%s'", cpu_model);
+ qts = qtest_initf("-machine none -cpu '%s'", cpu_model);
- response = qmp("{ 'execute': 'quit' }");
+ response = qtest_qmp(qts, "{ 'execute': 'quit' }");
g_assert(qdict_haskey(response, "return"));
qobject_unref(response);
- qtest_quit(global_qtest);
+ qtest_quit(qts);
}
int main(int argc, char **argv)
--
1.8.3.1
next prev parent reply other threads:[~2018-12-17 16:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 16:21 [Qemu-devel] [PULL 00/13] qtest patches Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 01/13] tests/libqos/pci: Make PCI access functions independent of global_qtest Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 02/13] ivshmem-test: Drop dependence on global_qtest Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 03/13] tests/acpi-utils: " Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 04/13] tests/vmgenid: Make test independent of global_qtest Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 05/13] tests/pvpanic: Make the pvpanic " Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 06/13] tests/boot-serial: Get rid of global_qtest variable Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 07/13] tests/test-filter: Make tests independent of global_qtest Thomas Huth
2018-12-17 16:21 ` Thomas Huth [this message]
2018-12-17 16:21 ` [Qemu-devel] [PULL 09/13] tests/prom-env: Make test " Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 10/13] tests/pxe: " Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 11/13] tests: Exit boot-serial-test loop if child dies Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 12/13] tests: acpi: remove not used ACPI_READ_GENERIC_ADDRESS macro Thomas Huth
2018-12-17 16:21 ` [Qemu-devel] [PULL 13/13] tests/bios-tables-test: Sanitize test verbose output Thomas Huth
2018-12-18 17:21 ` [Qemu-devel] [PULL 00/13] qtest patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545063690-10116-9-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).