* [Qemu-devel] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file
@ 2019-01-04 15:02 Thomas Huth
2019-01-09 10:18 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-01-10 8:52 ` [Qemu-devel] " Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2019-01-04 15:02 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: qemu-trivial, Jan Kiszka, qemu-arm
This device does not use I2C, so no need to include the header file here.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/audio/marvell_88w8618.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c
index 6600ab4..035dd76 100644
--- a/hw/audio/marvell_88w8618.c
+++ b/hw/audio/marvell_88w8618.c
@@ -12,7 +12,6 @@
#include "qemu/osdep.h"
#include "hw/sysbus.h"
#include "hw/hw.h"
-#include "hw/i2c/i2c.h"
#include "hw/audio/wm8750.h"
#include "audio/audio.h"
#include "qapi/error.h"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file
2019-01-04 15:02 [Qemu-devel] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file Thomas Huth
@ 2019-01-09 10:18 ` Laurent Vivier
2019-01-10 8:52 ` [Qemu-devel] " Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-01-09 10:18 UTC (permalink / raw)
To: Thomas Huth, Gerd Hoffmann, qemu-devel; +Cc: qemu-trivial, qemu-arm, Jan Kiszka
On 04/01/2019 16:02, Thomas Huth wrote:
> This device does not use I2C, so no need to include the header file here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/audio/marvell_88w8618.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c
> index 6600ab4..035dd76 100644
> --- a/hw/audio/marvell_88w8618.c
> +++ b/hw/audio/marvell_88w8618.c
> @@ -12,7 +12,6 @@
> #include "qemu/osdep.h"
> #include "hw/sysbus.h"
> #include "hw/hw.h"
> -#include "hw/i2c/i2c.h"
> #include "hw/audio/wm8750.h"
> #include "audio/audio.h"
> #include "qapi/error.h"
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file
2019-01-04 15:02 [Qemu-devel] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file Thomas Huth
2019-01-09 10:18 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
@ 2019-01-10 8:52 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2019-01-10 8:52 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, qemu-trivial, Jan Kiszka, qemu-arm
On Fri, Jan 04, 2019 at 04:02:26PM +0100, Thomas Huth wrote:
> This device does not use I2C, so no need to include the header file here.
Added to audio queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-10 8:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-04 15:02 [Qemu-devel] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file Thomas Huth
2019-01-09 10:18 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-01-10 8:52 ` [Qemu-devel] " Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).