qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pierre Morel <pmorel@linux.ibm.com>
To: walling@linux.ibm.com
Cc: borntraeger@de.ibm.com, cohuck@redhat.com, rth@twiddle.net,
	david@redhat.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	pasic@linux.ibm.com, thuth@redhat.com
Subject: [Qemu-devel] [PATCH v7] s390x/pci: add common fmb
Date: Tue,  8 Jan 2019 18:37:29 +0100	[thread overview]
Message-ID: <1546969050-8884-1-git-send-email-pmorel@linux.ibm.com> (raw)

After the last review round I and use the sizeof of the source entry
in the fmb_do_update() function instead of the target entry.
Anyway they both are the same size but it may be easier to read.

Regards,
Pierre

Yi Min Zhao (1):
  s390x/pci: add common function measurement block

 hw/s390x/s390-pci-bus.c  |   4 +-
 hw/s390x/s390-pci-bus.h  |  29 +++++++++++
 hw/s390x/s390-pci-inst.c | 133 +++++++++++++++++++++++++++++++++++++++++++++--
 hw/s390x/s390-pci-inst.h |   1 +
 4 files changed, 163 insertions(+), 4 deletions(-)

-- 
2.7.4

Changelog:

from v6:
- let the compiler calculate the sizeof target entry
  using the source size (was using target size)
  but of course they should (and are) the same

from v5:
- let the compiler calculate the sizeof target entry.

from v4:
- commit message
- use sizeof target of the fmb_do_update

from v3:
- changed commit message according to Conny's comments

In s390-pci-inst.c
- simplify the fmb_do_update() to handle
  all cases from byte to quad. (Conny)

from v2:
In s390-pci-bus:
- Initialize the FMB Format.

In s390-pci-bus.h
- re-organization of the internal counters, having a table for the
  internal counters.

In s390-pci-inst.c
- Internal counters update (LD/ST/STB/RPCIT) is done always.
  even if the FMB if fmb_addr is NULL.
  AFAIU this respect the documentation which only states that FMB
  update is stopped.
- in mpcifc_service_call(), moved the setting of fmb_addr after
  the timer has been stopped.
- fmb_update((), use address_space_stq_be() to handle endianness
  when storing the FMB.
- define the format with 32 bits instead of one char and reserved
  chars, this is easier to handle the FMB copy.
- No update of the DMA fields inside the FMB, as stipulated by the
  documentation when format32 is 0.

             reply	other threads:[~2019-01-08 17:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08 17:37 Pierre Morel [this message]
2019-01-08 17:37 ` [Qemu-devel] [PATCH v7] s390x/pci: add common function measurement block Pierre Morel
2019-01-09 11:29   ` David Hildenbrand
2019-01-09 11:43     ` David Hildenbrand
2019-01-14  9:18       ` Pierre Morel
2019-01-14  9:23         ` David Hildenbrand
2019-01-14  9:31           ` Pierre Morel
2019-01-14  9:44           ` Cornelia Huck
2019-01-17 15:44             ` [Qemu-devel] [qemu-s390x] " Collin Walling
2019-01-17 16:37   ` [Qemu-devel] " Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1546969050-8884-1-git-send-email-pmorel@linux.ibm.com \
    --to=pmorel@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    --cc=walling@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).