From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, war2jordan@live.com,
crosthwaite.peter@gmail.com, boost.lists@gmail.com,
artem.k.pisarenko@gmail.com, quintela@redhat.com,
ciro.santilli@gmail.com, jasowang@redhat.com, mst@redhat.com,
armbru@redhat.com, mreitz@redhat.com,
maria.klimushenkova@ispras.ru, dovgaluk@ispras.ru,
kraxel@redhat.com, pavel.dovgaluk@ispras.ru,
thomas.dullien@googlemail.com, pbonzini@redhat.com,
alex.bennee@linaro.org, dgilbert@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v9 21/21] replay: document development rules
Date: Wed, 09 Jan 2019 15:13:21 +0300 [thread overview]
Message-ID: <154703600185.13472.14578327407784304841.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <154703587757.13472.3898702635363120794.stgit@pasha-VirtualBox>
This patch introduces docs/devel/replay.txt which describes the rules
that should be followed to make virtual devices usable in record/replay mode.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgauk@ispras.ru>
--
v9: fixed external virtual clock description (reported by Artem Pisarenko)
---
docs/devel/replay.txt | 46 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
create mode 100644 docs/devel/replay.txt
diff --git a/docs/devel/replay.txt b/docs/devel/replay.txt
new file mode 100644
index 0000000..e641c35
--- /dev/null
+++ b/docs/devel/replay.txt
@@ -0,0 +1,46 @@
+Record/replay mechanism, that could be enabled through icount mode, expects
+the virtual devices to satisfy the following requirements.
+
+The main idea behind this document is that everything that affects
+the guest state during execution in icount mode should be deterministic.
+
+Timers
+======
+
+All virtual devices should use virtual clock for timers that change the guest
+state. Virtual clock is deterministic, therefore such timers are deterministic
+too.
+
+Virtual devices can also use realtime clock for the events that do not change
+the guest state directly. When the clock ticking should depend on VM execution
+speed, use virtual clock with EXTERNAL attribute. It is not deterministic,
+but its speed depends on the guest execution. This clock is used by
+the virtual devices (e.g., slirp routing device) that lie outside the
+replayed guest.
+
+Bottom halves
+=============
+
+Bottom half callbacks, that affect the guest state, should be invoked through
+replay_bh_schedule_event or replay_bh_schedule_oneshot_event functions.
+Their invocations are saved in record mode and synchronized with the existing
+log in replay mode.
+
+Saving/restoring the VM state
+=============================
+
+All fields in the device state structure (including virtual timers)
+should be restored by loadvm to the same values they had before savevm.
+
+Avoid accessing other devices' state, because the order of saving/restoring
+is not defined. It means that you should not call functions like
+'update_irq' in post_load callback. Save everything explicitly to avoid
+the dependencies that may make restoring the VM state non-deterministic.
+
+Stopping the VM
+===============
+
+Stopping the guest should not interfere with its state (with the exception
+of the network connections, that could be broken by the remote timeouts).
+VM can be stopped at any moment of replay by the user. Restarting the VM
+after that stop should not break the replay by the unneeded guest state change.
next prev parent reply other threads:[~2019-01-09 12:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 12:11 [Qemu-devel] [PATCH v9 00/21] Fixing record/replay and adding reverse debugging Pavel Dovgalyuk
2019-01-09 12:11 ` [Qemu-devel] [PATCH v9 01/21] replay: add missing fix for internal function Pavel Dovgalyuk
2019-01-09 12:11 ` [Qemu-devel] [PATCH v9 02/21] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2019-01-09 12:11 ` [Qemu-devel] [PATCH v9 03/21] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2019-01-09 12:11 ` [Qemu-devel] [PATCH v9 04/21] replay: update docs for record/replay with block devices Pavel Dovgalyuk
2019-01-09 12:11 ` [Qemu-devel] [PATCH v9 05/21] replay: don't drain/flush bdrv queue while RR is working Pavel Dovgalyuk
2019-01-09 12:11 ` [Qemu-devel] [PATCH v9 06/21] replay: finish record/replay before closing the disks Pavel Dovgalyuk
2019-01-09 12:12 ` [Qemu-devel] [PATCH v9 07/21] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2019-01-09 12:12 ` [Qemu-devel] [PATCH v9 08/21] migration: " Pavel Dovgalyuk
2019-01-11 8:01 ` Markus Armbruster
2019-01-09 12:12 ` [Qemu-devel] [PATCH v9 09/21] replay: provide and accessor for rr filename Pavel Dovgalyuk
2019-01-09 16:27 ` Markus Armbruster
2019-01-09 12:12 ` [Qemu-devel] [PATCH v9 10/21] qapi: introduce replay.json for record/replay-related stuff Pavel Dovgalyuk
2019-01-10 10:34 ` Markus Armbruster
2019-01-14 8:31 ` Pavel Dovgalyuk
2019-01-09 12:12 ` [Qemu-devel] [PATCH v9 11/21] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2019-01-11 8:27 ` Markus Armbruster
2019-01-14 9:01 ` Pavel Dovgalyuk
2019-01-09 12:12 ` [Qemu-devel] [PATCH v9 12/21] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2019-01-11 8:38 ` Markus Armbruster
2019-01-09 12:12 ` [Qemu-devel] [PATCH v9 13/21] replay: implement replay-seek command to proceed to the desired step Pavel Dovgalyuk
2019-01-11 8:58 ` Markus Armbruster
2019-01-14 9:36 ` Pavel Dovgalyuk
2019-01-09 12:12 ` [Qemu-devel] [PATCH v9 14/21] replay: refine replay-time module Pavel Dovgalyuk
2019-01-09 12:12 ` [Qemu-devel] [PATCH v9 15/21] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2019-01-09 12:12 ` [Qemu-devel] [PATCH v9 16/21] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2019-01-09 12:12 ` [Qemu-devel] [PATCH v9 17/21] gdbstub: add reverse continue " Pavel Dovgalyuk
2019-01-09 12:13 ` [Qemu-devel] [PATCH v9 18/21] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2019-01-09 12:13 ` [Qemu-devel] [PATCH v9 19/21] replay: add BH oneshot event for block layer Pavel Dovgalyuk
2019-01-11 10:49 ` Kevin Wolf
2019-01-14 11:10 ` Pavel Dovgalyuk
2019-01-14 11:35 ` Kevin Wolf
2019-01-14 11:48 ` Pavel Dovgalyuk
2019-02-13 5:47 ` Pavel Dovgalyuk
2019-01-09 12:13 ` [Qemu-devel] [PATCH v9 20/21] replay: init rtc after enabling the replay Pavel Dovgalyuk
2019-01-09 12:13 ` Pavel Dovgalyuk [this message]
2019-01-13 14:24 ` [Qemu-devel] [PATCH v9 00/21] Fixing record/replay and adding reverse debugging no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154703600185.13472.14578327407784304841.stgit@pasha-VirtualBox \
--to=pavel.dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=artem.k.pisarenko@gmail.com \
--cc=boost.lists@gmail.com \
--cc=ciro.santilli@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=thomas.dullien@googlemail.com \
--cc=war2jordan@live.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).