From: Thomas Huth <thuth@redhat.com>
To: "Richard Henderson" <rth@twiddle.net>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Cornelia Huck" <cohuck@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org
Subject: [Qemu-devel] [PATCH] include/fpu/softfloat: Fix compilation with Clang on s390x
Date: Mon, 14 Jan 2019 13:12:35 +0100 [thread overview]
Message-ID: <1547467955-17245-1-git-send-email-thuth@redhat.com> (raw)
Clang v7.0.1 does not like the __int128 variable type for inline
assembly on s390x:
In file included from fpu/softfloat.c:97:
include/fpu/softfloat-macros.h:647:9: error: inline asm error:
This value type register class is not natively supported!
asm("dlgr %0, %1" : "+r"(n) : "r"(d));
^
Disable this code part there now when compiling with Clang, so that
the generic code gets used instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
include/fpu/softfloat-macros.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/fpu/softfloat-macros.h b/include/fpu/softfloat-macros.h
index b1d772e..bd5b641 100644
--- a/include/fpu/softfloat-macros.h
+++ b/include/fpu/softfloat-macros.h
@@ -641,7 +641,7 @@ static inline uint64_t udiv_qrnnd(uint64_t *r, uint64_t n1,
uint64_t q;
asm("divq %4" : "=a"(q), "=d"(*r) : "0"(n0), "1"(n1), "rm"(d));
return q;
-#elif defined(__s390x__)
+#elif defined(__s390x__) && !defined(__clang__)
/* Need to use a TImode type to get an even register pair for DLGR. */
unsigned __int128 n = (unsigned __int128)n1 << 64 | n0;
asm("dlgr %0, %1" : "+r"(n) : "r"(d));
--
1.8.3.1
next reply other threads:[~2019-01-14 12:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 12:12 Thomas Huth [this message]
2019-01-14 12:16 ` [Qemu-devel] [PATCH] include/fpu/softfloat: Fix compilation with Clang on s390x Philippe Mathieu-Daudé
2019-01-14 16:37 ` Alex Bennée
2019-01-14 17:03 ` Thomas Huth
2019-01-14 18:58 ` Alex Bennée
2019-01-14 21:36 ` Richard Henderson
2019-01-14 22:48 ` Alex Bennée
2019-01-15 10:14 ` Peter Maydell
2019-01-15 14:46 ` Alex Bennée
2019-01-15 15:29 ` Thomas Huth
2019-01-15 16:01 ` Alex Bennée
2019-01-15 20:05 ` Emilio G. Cota
2019-01-16 6:33 ` Thomas Huth
2019-01-16 17:08 ` Alex Bennée
2019-01-17 6:06 ` Thomas Huth
2019-01-17 7:42 ` Alex Bennée
2019-01-16 18:21 ` Emilio G. Cota
2019-01-15 22:05 ` Richard Henderson
2019-01-14 21:40 ` Richard Henderson
2019-01-16 16:50 ` Cornelia Huck
2019-01-16 17:16 ` Alex Bennée
2019-01-17 5:57 ` Thomas Huth
2019-01-17 8:30 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547467955-17245-1-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=cohuck@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).