[Qemu-devel] [PATCH] tap: flush STDOUT on newline

[Qemu-devel] [PATCH] tap: flush STDOUT on newline

[Paolo Bonzini]

This makes it easier to follow what is going on.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/tap-driver.pl | 1 +
 scripts/tap-merge.pl  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/scripts/tap-driver.pl b/scripts/tap-driver.pl
index 5e59b5d..6621a5c 100755
--- a/scripts/tap-driver.pl
+++ b/scripts/tap-driver.pl
@@ -313,6 +313,7 @@ sub main ()
   my $iterator = TAP::Parser::Iterator::Stream->new(\*STDIN);
   my $parser = TAP::Parser->new ({iterator => $iterator });
 
+  STDOUT->autoflush(1);
   while (defined (my $cur = $parser->next))
     {
       # Parsing of TAP input should stop after a "Bail out!" directive.
diff --git a/scripts/tap-merge.pl b/scripts/tap-merge.pl
index 59e3fa5..10ccf57 100755
--- a/scripts/tap-merge.pl
+++ b/scripts/tap-merge.pl
@@ -53,6 +53,7 @@ sub main ()
   my $testno = 0;     # Number of test results seen so far.
   my $bailed_out = 0; # Whether a "Bail out!" directive has been seen.
 
+  STDOUT->autoflush(1);
   while (defined (my $cur = $parser->next))
     {
       if ($cur->is_bailout)
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] tap: flush STDOUT on newline

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

On 1/15/19 11:56 AM, Paolo Bonzini wrote:
> This makes it easier to follow what is going on.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  scripts/tap-driver.pl | 1 +
>  scripts/tap-merge.pl  | 1 +
>  2 files changed, 2 insertions(+)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [Qemu-devel] [PATCH] tap: flush STDOUT on newline

[Philippe Mathieu-Daudé]

On 1/15/19 6:56 PM, Paolo Bonzini wrote:
> This makes it easier to follow what is going on.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  scripts/tap-driver.pl | 1 +
>  scripts/tap-merge.pl  | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/scripts/tap-driver.pl b/scripts/tap-driver.pl
> index 5e59b5d..6621a5c 100755
> --- a/scripts/tap-driver.pl
> +++ b/scripts/tap-driver.pl
> @@ -313,6 +313,7 @@ sub main ()
>    my $iterator = TAP::Parser::Iterator::Stream->new(\*STDIN);
>    my $parser = TAP::Parser->new ({iterator => $iterator });
>  
> +  STDOUT->autoflush(1);
>    while (defined (my $cur = $parser->next))
>      {
>        # Parsing of TAP input should stop after a "Bail out!" directive.
> diff --git a/scripts/tap-merge.pl b/scripts/tap-merge.pl
> index 59e3fa5..10ccf57 100755
> --- a/scripts/tap-merge.pl
> +++ b/scripts/tap-merge.pl
> @@ -53,6 +53,7 @@ sub main ()
>    my $testno = 0;     # Number of test results seen so far.
>    my $bailed_out = 0; # Whether a "Bail out!" directive has been seen.
>  
> +  STDOUT->autoflush(1);
>    while (defined (my $cur = $parser->next))
>      {
>        if ($cur->is_bailout)
> 

Re: [Qemu-devel] [PATCH] tap: flush STDOUT on newline

[no-reply]

Patchew URL: https://patchew.org/QEMU/1547574976-6372-1-git-send-email-pbonzini@redhat.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14
=== TEST SCRIPT END ===

  CC      device_tree.o
  CC      qapi/qapi-commands.o
/tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name':
/tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation]
     strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


The full log is available at
http://patchew.org/logs/1547574976-6372-1-git-send-email-pbonzini@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com