From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: pasic@linux.ibm.com, borntraeger@de.ibm.com,
qemu-s390x@nongnu.org, cohuck@redhat.com, rth@twiddle.net,
david@redhat.com, philmd@redhat.com
Subject: [Qemu-devel] [PATCH v3] s390x: remove direct reference to mem_path global form s390x code
Date: Mon, 28 Jan 2019 16:32:38 +0100 [thread overview]
Message-ID: <1548689558-23960-1-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <ae5efb07-6079-e102-4c21-65bdd5c9d9a2@redhat.com>
I plan to deprecate -mem-path option and replace it with memory-backend,
for that it's necessary to get rid of mem_path global variable.
Do it for s390x case, replacing it with alternative way to enable
1Mb hugepages capability.
To do that, replace qemu_mempath_getpagesize() with qemu_getrampagesize()
which also checks for -mem-path provided RAM.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
v3:
fixup, typo in commit msg (Philippe Mathieu-Daudé <philmd@redhat.com>)
v2:
* s/qemu_mempath_getpagesize/qemu_getrampagesiz/ and drop the rest of changes
David Hildenbrand <david@redhat.com>
---
target/s390x/kvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index 2ebf26a..90766fa 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -287,7 +287,7 @@ void kvm_s390_crypto_reset(void)
static int kvm_s390_configure_mempath_backing(KVMState *s)
{
- size_t path_psize = qemu_mempath_getpagesize(mem_path);
+ size_t path_psize = qemu_getrampagesize();
if (path_psize == 4 * KiB) {
return 0;
@@ -319,7 +319,7 @@ int kvm_arch_init(MachineState *ms, KVMState *s)
{
MachineClass *mc = MACHINE_GET_CLASS(ms);
- if (mem_path && kvm_s390_configure_mempath_backing(s)) {
+ if (kvm_s390_configure_mempath_backing(s)) {
return -EINVAL;
}
--
2.7.4
next prev parent reply other threads:[~2019-01-28 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 12:31 [Qemu-devel] [PATCH v2] s390x: remove direct reference to mem_path global form s390x code Igor Mammedov
2019-01-28 12:46 ` David Hildenbrand
2019-01-28 14:55 ` Philippe Mathieu-Daudé
2019-01-28 15:32 ` Igor Mammedov [this message]
2019-01-29 12:39 ` [Qemu-devel] [PATCH v3] " Cornelia Huck
2019-01-29 14:43 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548689558-23960-1-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).