From: Catherine Ho <catherine.hecx@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>,
"Emilio G. Cota" <cota@braap.org>
Cc: qemu-devel@nongnu.org, Catherine Ho <catherine.hecx@gmail.com>
Subject: [Qemu-devel] [PATCH] tcg: add early clober modifier in atomic16_cmpxchg on aarch64
Date: Wed, 30 Jan 2019 03:59:54 -0500 [thread overview]
Message-ID: <1548838794-23757-1-git-send-email-catherine.hecx@gmail.com> (raw)
Without this patch, gcc might up the Input/Output registers and
cause unpredictable error.
Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128")
Signed-off-by: Catherine Ho <catherine.hecx@gmail.com>
---
include/qemu/atomic128.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qemu/atomic128.h b/include/qemu/atomic128.h
index a6af22ff10..ddd0d55d31 100644
--- a/include/qemu/atomic128.h
+++ b/include/qemu/atomic128.h
@@ -68,7 +68,7 @@ static inline Int128 atomic16_cmpxchg(Int128 *ptr, Int128 cmp, Int128 new)
"cbnz %w[tmp], 0b\n"
"1:"
: [mem] "+m"(*ptr), [tmp] "=&r"(tmp),
- [oldl] "=&r"(oldl), [oldh] "=r"(oldh)
+ [oldl] "=&r"(oldl), [oldh] "=&r"(oldh)
: [cmpl] "r"(cmpl), [cmph] "r"(cmph),
[newl] "r"(newl), [newh] "r"(newh)
: "memory", "cc");
--
2.17.1
next reply other threads:[~2019-01-30 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 8:59 Catherine Ho [this message]
2019-01-31 21:43 ` [Qemu-devel] [PATCH] tcg: add early clober modifier in atomic16_cmpxchg on aarch64 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548838794-23757-1-git-send-email-catherine.hecx@gmail.com \
--to=catherine.hecx@gmail.com \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).