* [Qemu-devel] [PATCH] tcg: add early clober modifier in atomic16_cmpxchg on aarch64
@ 2019-01-30 8:59 Catherine Ho
2019-01-31 21:43 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Catherine Ho @ 2019-01-30 8:59 UTC (permalink / raw)
To: Richard Henderson, Emilio G. Cota; +Cc: qemu-devel, Catherine Ho
Without this patch, gcc might up the Input/Output registers and
cause unpredictable error.
Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128")
Signed-off-by: Catherine Ho <catherine.hecx@gmail.com>
---
include/qemu/atomic128.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qemu/atomic128.h b/include/qemu/atomic128.h
index a6af22ff10..ddd0d55d31 100644
--- a/include/qemu/atomic128.h
+++ b/include/qemu/atomic128.h
@@ -68,7 +68,7 @@ static inline Int128 atomic16_cmpxchg(Int128 *ptr, Int128 cmp, Int128 new)
"cbnz %w[tmp], 0b\n"
"1:"
: [mem] "+m"(*ptr), [tmp] "=&r"(tmp),
- [oldl] "=&r"(oldl), [oldh] "=r"(oldh)
+ [oldl] "=&r"(oldl), [oldh] "=&r"(oldh)
: [cmpl] "r"(cmpl), [cmph] "r"(cmph),
[newl] "r"(newl), [newh] "r"(newh)
: "memory", "cc");
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: add early clober modifier in atomic16_cmpxchg on aarch64
2019-01-30 8:59 [Qemu-devel] [PATCH] tcg: add early clober modifier in atomic16_cmpxchg on aarch64 Catherine Ho
@ 2019-01-31 21:43 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2019-01-31 21:43 UTC (permalink / raw)
To: Catherine Ho, Emilio G. Cota; +Cc: qemu-devel
On 1/30/19 12:59 AM, Catherine Ho wrote:
> Without this patch, gcc might up the Input/Output registers and
> cause unpredictable error.
>
> Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128")
>
> Signed-off-by: Catherine Ho <catherine.hecx@gmail.com>
Queued, thanks.
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-31 21:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-30 8:59 [Qemu-devel] [PATCH] tcg: add early clober modifier in atomic16_cmpxchg on aarch64 Catherine Ho
2019-01-31 21:43 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).