From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA185C2BA1A for ; Fri, 24 Apr 2020 10:42:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4D272071E for ; Fri, 24 Apr 2020 10:42:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fX8yCnFA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4D272071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRvml-0003LA-Pb for qemu-devel@archiver.kernel.org; Fri, 24 Apr 2020 06:42:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41188) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRvln-0001x6-Ct for qemu-devel@nongnu.org; Fri, 24 Apr 2020 06:41:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRvln-0002qB-0l for qemu-devel@nongnu.org; Fri, 24 Apr 2020 06:41:19 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:41561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jRvlm-0002iq-If for qemu-devel@nongnu.org; Fri, 24 Apr 2020 06:41:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587724877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bztYjvJzjsXp4icoK49+vXwg4ZJ6fTGwDH1Z/9nmfYw=; b=fX8yCnFAlVkmzCWCYTNB3Is9FBlfCYC35lMEwBB3ilAXxFziY+uEvJ2764qXLmDx/5hIad J0zq45lMU7Oha+wjzLuX36/udEzzZkLWDJXcO0/JQEDLM+veq/QpGhB+P9mhJKpWzC3T+O 6pFRX7Dy9MUAS8n05+wGV9MiyoQ3/yA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-4-ZL7RyPG9M96dE-HjpSeYfw-1; Fri, 24 Apr 2020 06:41:15 -0400 X-MC-Unique: ZL7RyPG9M96dE-HjpSeYfw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E21E800C78; Fri, 24 Apr 2020 10:41:14 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-113-192.ams2.redhat.com [10.36.113.192]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D2A6600E8; Fri, 24 Apr 2020 10:41:13 +0000 (UTC) Subject: Re: [PATCH v2 3/3] qcow2: Tweak comment about bitmaps vs. resize To: Eric Blake , qemu-devel@nongnu.org References: <20200423221707.477404-1-eblake@redhat.com> <20200423221707.477404-4-eblake@redhat.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <154895e4-a93a-575d-1174-42c47887988e@redhat.com> Date: Fri, 24 Apr 2020 12:41:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200423221707.477404-4-eblake@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j3WiquyFjqu6X3G1tCT1OSQfBncRjv7TY" Received-SPF: pass client-ip=205.139.110.61; envelope-from=mreitz@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/24 02:57:59 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --j3WiquyFjqu6X3G1tCT1OSQfBncRjv7TY Content-Type: multipart/mixed; boundary="wIF8HJI5l1APi5luu0e8w0O6ijWOFPSou" --wIF8HJI5l1APi5luu0e8w0O6ijWOFPSou Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 24.04.20 00:17, Eric Blake wrote: > Our comment did not actually match the code. Rewrite the comment to > be less sensitive to any future changes to qcow2-bitmap.c that might > implement scenarios that we currently reject. >=20 > Signed-off-by: Eric Blake > --- > block/qcow2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/block/qcow2.c b/block/qcow2.c > index 34888a793354..6b6d1c3fa8b9 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -3997,7 +3997,7 @@ static int coroutine_fn qcow2_co_truncate(BlockDriv= erState *bs, int64_t offset, > goto fail; > } >=20 > - /* cannot proceed if image has bitmaps */ > + /* See qcow2-bitmap.c for which bitmap scenarios prevent a resize. *= / Clever. ;) Reviewed-by: Max Reitz > if (qcow2_truncate_bitmaps_check(bs, errp)) { > ret =3D -ENOTSUP; > goto fail; >=20 --wIF8HJI5l1APi5luu0e8w0O6ijWOFPSou-- --j3WiquyFjqu6X3G1tCT1OSQfBncRjv7TY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl6iwkcACgkQ9AfbAGHV z0BPMwf/YeB3wxrZXSe5VUanbzaQNbvY9oaxS0DRyIZ6LBNx2740fr7B79DxMwk8 svQHk3jZ15fVWI1bZWspj+3gg+yHggaMKE4LxfUPynVY5Pd/VwA9utVn3sHz6sJJ EUD+xWrdomQNwqC5VQHYbZMzZ7CePh0zVmfUqyvYCYeNoK/cMJJqpO5SOzuqgLYG wJ3//1hchRXj4w1rAiemaOMaRSpIHTVRnzL1o5zv9jO5BiNwO8gxSUgAYW1gJRub 15DIjMM1VwyJbHW7/MS+QMny2L4Z2kbrCGd6yrB3rYwQIuSQsDYZIXqsBSAVQqbi 5gfb1VrN+BYPaD/JI0W6sto6dq0/oQ== =ZLmH -----END PGP SIGNATURE----- --j3WiquyFjqu6X3G1tCT1OSQfBncRjv7TY--