qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, war2jordan@live.com,
	crosthwaite.peter@gmail.com, boost.lists@gmail.com,
	artem.k.pisarenko@gmail.com, quintela@redhat.com,
	ciro.santilli@gmail.com, jasowang@redhat.com, mst@redhat.com,
	armbru@redhat.com, mreitz@redhat.com,
	maria.klimushenkova@ispras.ru, dovgaluk@ispras.ru,
	kraxel@redhat.com, pavel.dovgaluk@ispras.ru,
	thomas.dullien@googlemail.com, pbonzini@redhat.com,
	alex.bennee@linaro.org, dgilbert@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v12 06/25] replay: finish record/replay before closing the disks
Date: Tue, 05 Feb 2019 11:20:15 +0300	[thread overview]
Message-ID: <154935481562.7509.3286769643322025195.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <154935478086.7509.4349987292919289245.stgit@pasha-VirtualBox>

After recent updates block devices cannot be closed on qemu exit.
This happens due to the block request polling when replay is not finished.
Therefore now we stop execution recording before closing the block devices.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 replay/replay.c |    2 ++
 vl.c            |    1 +
 2 files changed, 3 insertions(+)

diff --git a/replay/replay.c b/replay/replay.c
index 8b172b2d1b..b75820a1c1 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -385,6 +385,8 @@ void replay_finish(void)
     g_free(replay_snapshot);
     replay_snapshot = NULL;
 
+    replay_mode = REPLAY_MODE_NONE;
+
     replay_finish_events();
 }
 
diff --git a/vl.c b/vl.c
index 8b97ed7b3f..00cf47339e 100644
--- a/vl.c
+++ b/vl.c
@@ -4674,6 +4674,7 @@ int main(int argc, char **argv, char **envp)
 
     /* No more vcpu or device emulation activity beyond this point */
     vm_shutdown();
+    replay_finish();
 
     job_cancel_sync_all();
     bdrv_close_all();

  parent reply	other threads:[~2019-02-05  8:20 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05  8:19 [Qemu-devel] [PATCH v12 00/25] Fixing record/replay and adding reverse debugging Pavel Dovgalyuk
2019-02-05  8:19 ` [Qemu-devel] [PATCH v12 01/25] replay: add missing fix for internal function Pavel Dovgalyuk
2019-02-05  8:19 ` [Qemu-devel] [PATCH v12 02/25] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2019-02-05  8:19 ` [Qemu-devel] [PATCH v12 03/25] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2019-02-05  8:20 ` [Qemu-devel] [PATCH v12 04/25] replay: update docs for record/replay with block devices Pavel Dovgalyuk
2019-02-05  8:20 ` [Qemu-devel] [PATCH v12 05/25] replay: don't drain/flush bdrv queue while RR is working Pavel Dovgalyuk
2019-02-05  8:20 ` Pavel Dovgalyuk [this message]
2019-02-05  8:20 ` [Qemu-devel] [PATCH v12 07/25] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2019-02-05  8:20 ` [Qemu-devel] [PATCH v12 08/25] migration: " Pavel Dovgalyuk
2019-02-05  8:20 ` [Qemu-devel] [PATCH v12 09/25] replay: provide an accessor for rr filename Pavel Dovgalyuk
2019-02-05  8:20 ` [Qemu-devel] [PATCH v12 10/25] qapi: introduce replay.json for record/replay-related stuff Pavel Dovgalyuk
2019-02-05  8:20 ` [Qemu-devel] [PATCH v12 11/25] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2019-02-05  8:20 ` [Qemu-devel] [PATCH v12 12/25] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2019-02-05  8:20 ` [Qemu-devel] [PATCH v12 13/25] replay: implement replay-seek command Pavel Dovgalyuk
2019-02-05  8:21 ` [Qemu-devel] [PATCH v12 14/25] replay: refine replay-time module Pavel Dovgalyuk
2019-02-05  8:21 ` [Qemu-devel] [PATCH v12 15/25] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2019-02-05  8:21 ` [Qemu-devel] [PATCH v12 16/25] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2019-02-05  8:21 ` [Qemu-devel] [PATCH v12 17/25] gdbstub: add reverse continue " Pavel Dovgalyuk
2019-02-05  8:21 ` [Qemu-devel] [PATCH v12 18/25] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2019-02-05  8:21 ` [Qemu-devel] [PATCH v12 19/25] replay: add BH oneshot event for block layer Pavel Dovgalyuk
2019-02-05  8:21 ` [Qemu-devel] [PATCH v12 20/25] replay: init rtc after enabling the replay Pavel Dovgalyuk
2019-02-05  8:21 ` [Qemu-devel] [PATCH v12 21/25] replay: document development rules Pavel Dovgalyuk
2019-02-05  8:21 ` [Qemu-devel] [PATCH v12 22/25] util/qemu-timer: refactor deadline calculation for external timers Pavel Dovgalyuk
2019-02-05  8:21 ` [Qemu-devel] [PATCH v12 23/25] replay: fix replay shutdown Pavel Dovgalyuk
2019-02-05  8:21 ` [Qemu-devel] [PATCH v12 24/25] replay: rename step-related variables and functions Pavel Dovgalyuk
2019-02-05  8:22 ` [Qemu-devel] [PATCH v12 25/25] icount: clean up cpu_can_io before jumping to the next block Pavel Dovgalyuk
2019-02-11 12:41 ` [Qemu-devel] [PATCH v12 00/25] Fixing record/replay and adding reverse debugging Pavel Dovgalyuk
2019-02-12  7:14   ` Markus Armbruster
2019-02-12  7:18     ` dovgaluk
2019-02-12  9:18       ` Markus Armbruster
2019-02-18  5:21         ` Pavel Dovgalyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154935481562.7509.3286769643322025195.stgit@pasha-VirtualBox \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=artem.k.pisarenko@gmail.com \
    --cc=boost.lists@gmail.com \
    --cc=ciro.santilli@gmail.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=dovgaluk@ispras.ru \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=maria.klimushenkova@ispras.ru \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rth@twiddle.net \
    --cc=thomas.dullien@googlemail.com \
    --cc=war2jordan@live.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).