From: Liam Merwick <liam.merwick@oracle.com>
To: kraxel@redhat.com, qemu-devel@nongnu.org
Cc: liam.merwick@oracle.com, darren.kenny@oracle.com
Subject: [Qemu-devel] [PATCH v2 9/9] usb: remove unnecessary NULL device check from usb_ep_get()
Date: Wed, 6 Feb 2019 13:36:56 +0000 [thread overview]
Message-ID: <1549460216-25808-10-git-send-email-liam.merwick@oracle.com> (raw)
In-Reply-To: <1549460216-25808-1-git-send-email-liam.merwick@oracle.com>
No caller of usb_ep_get() calls it with a NULL device (previous commits
have addressed the few remaining cases which didn't explicitly check).
Replace check for 'dev == NULL' with an assert instead.
Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
---
hw/usb/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/usb/core.c b/hw/usb/core.c
index bfb7ae67bbf0..8fbd9c7d573b 100644
--- a/hw/usb/core.c
+++ b/hw/usb/core.c
@@ -717,9 +717,7 @@ struct USBEndpoint *usb_ep_get(USBDevice *dev, int pid, int ep)
{
struct USBEndpoint *eps;
- if (dev == NULL) {
- return NULL;
- }
+ assert(dev != NULL);
if (ep == 0) {
return &dev->ep_ctl;
}
--
1.8.3.1
next prev parent reply other threads:[~2019-02-06 13:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 13:36 [Qemu-devel] [PATCH v2 0/9] Dealing with Null devices in usb_ep_get() Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 1/9] usb: rearrange usb_ep_get() Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 2/9] xhci: add asserts to help with static code analysis Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 3/9] xhci: check device is not NULL before calling usb_ep_get() Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 4/9] ehci: " Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 5/9] ohci: " Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 6/9] uhci: " Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 7/9] usb: " Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 8/9] usb: add device checks before redirector calls to usb_ep_get() Liam Merwick
2019-02-06 13:36 ` Liam Merwick [this message]
2019-02-08 10:18 ` [Qemu-devel] [PATCH v2 0/9] Dealing with Null devices in usb_ep_get() Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549460216-25808-10-git-send-email-liam.merwick@oracle.com \
--to=liam.merwick@oracle.com \
--cc=darren.kenny@oracle.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).