qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Liam Merwick <liam.merwick@oracle.com>
To: kraxel@redhat.com, qemu-devel@nongnu.org
Cc: liam.merwick@oracle.com, darren.kenny@oracle.com
Subject: [Qemu-devel] [PATCH v2 8/9] usb: add device checks before redirector calls to usb_ep_get()
Date: Wed,  6 Feb 2019 13:36:55 +0000	[thread overview]
Message-ID: <1549460216-25808-9-git-send-email-liam.merwick@oracle.com> (raw)
In-Reply-To: <1549460216-25808-1-git-send-email-liam.merwick@oracle.com>

Add an assert and an explicit check before the two callers to
usb_ep_get() in the USB redirector code to ensure the device
passed in is not NULL.

Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
---
 hw/usb/redirect.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 18a42d19380e..7cb6b120d4f0 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -1728,6 +1728,7 @@ static void usbredir_ep_info(void *priv,
     USBRedirDevice *dev = priv;
     int i;
 
+    assert(dev != NULL);
     for (i = 0; i < MAX_ENDPOINTS; i++) {
         dev->endpoint[i].type = ep_info->type[i];
         dev->endpoint[i].interval = ep_info->interval[i];
@@ -2125,7 +2126,7 @@ static int usbredir_post_load(void *priv, int version_id)
 {
     USBRedirDevice *dev = priv;
 
-    if (dev->parser == NULL) {
+    if (dev == NULL || dev->parser == NULL) {
         return 0;
     }
 
-- 
1.8.3.1

  parent reply	other threads:[~2019-02-06 13:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-06 13:36 [Qemu-devel] [PATCH v2 0/9] Dealing with Null devices in usb_ep_get() Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 1/9] usb: rearrange usb_ep_get() Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 2/9] xhci: add asserts to help with static code analysis Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 3/9] xhci: check device is not NULL before calling usb_ep_get() Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 4/9] ehci: " Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 5/9] ohci: " Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 6/9] uhci: " Liam Merwick
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 7/9] usb: " Liam Merwick
2019-02-06 13:36 ` Liam Merwick [this message]
2019-02-06 13:36 ` [Qemu-devel] [PATCH v2 9/9] usb: remove unnecessary NULL device check from usb_ep_get() Liam Merwick
2019-02-08 10:18 ` [Qemu-devel] [PATCH v2 0/9] Dealing with Null devices in usb_ep_get() Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1549460216-25808-9-git-send-email-liam.merwick@oracle.com \
    --to=liam.merwick@oracle.com \
    --cc=darren.kenny@oracle.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).