From: Liam Merwick <liam.merwick@oracle.com>
To: stefanb@linux.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()
Date: Mon, 11 Feb 2019 15:03:05 +0000 [thread overview]
Message-ID: <1549897385-10091-3-git-send-email-liam.merwick@oracle.com> (raw)
In-Reply-To: <1549897385-10091-1-git-send-email-liam.merwick@oracle.com>
cppcheck reports:
[hw/tpm/tpm_tis.c:113]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'
Fix this by using %u instead of %d
Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
---
hw/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index 860c2ace7d99..395500e8a61d 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -110,7 +110,7 @@ static void tpm_tis_show_buffer(const unsigned char *buffer,
uint32_t len, i;
len = MIN(tpm_cmd_get_size(buffer), buffer_size);
- printf("tpm_tis: %s length = %d\n", string, len);
+ printf("tpm_tis: %s length = %u\n", string, len);
for (i = 0; i < len; i++) {
if (i && !(i % 16)) {
printf("\n");
--
1.8.3.1
next prev parent reply other threads:[~2019-02-11 15:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 15:03 [Qemu-devel] [PATCH v2 1/3] tpm_tis: fix loop that cancels any seizure by a lower locality Liam Merwick
2019-02-11 15:03 ` [Qemu-devel] [PATCH v2 2/3] tpm_tis: assert valid addr passed to tpm_tis_locality_from_addr() Liam Merwick
2019-02-12 17:29 ` Stefan Berger
2019-02-11 15:03 ` Liam Merwick [this message]
2019-02-11 16:02 ` [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer() Philippe Mathieu-Daudé
2019-02-11 19:56 ` Stefan Berger
2019-02-11 20:09 ` Liam Merwick
2019-02-11 21:13 ` Stefan Berger
2019-02-12 12:31 ` Philippe Mathieu-Daudé
2019-02-12 13:27 ` Stefan Berger
2019-02-12 13:43 ` Liam Merwick
2019-02-12 14:32 ` Philippe Mathieu-Daudé
2019-02-12 12:02 ` Stefan Berger
2019-02-11 20:53 ` [Qemu-devel] [PATCH v2 1/3] tpm_tis: fix loop that cancels any seizure by a lower locality Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549897385-10091-3-git-send-email-liam.merwick@oracle.com \
--to=liam.merwick@oracle.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).