* Re: [Qemu-devel] [PATCH] hw/sparc64: Explicitly set default_display = "std"
2019-02-13 7:07 [Qemu-devel] [PATCH] hw/sparc64: Explicitly set default_display = "std" Thomas Huth
@ 2019-02-13 11:22 ` Philippe Mathieu-Daudé
2019-02-13 12:44 ` Mark Cave-Ayland
2019-02-14 10:03 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-13 11:22 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Mark Cave-Ayland
Cc: Artyom Tarasenko, pbonzini, yang.zhong, qemu-trivial
On 2/13/19 8:07 AM, Thomas Huth wrote:
> The sun4uv_init() function expects vga_interface_type to be either
> VGA_STD or VGA_NONE and sets up a stdvga device or no vga card
> accordingly.
> However, the code in vl.c prefers the Cirrus VGA card to stdvga if
> it is available and the user and the machine did not specify anything
> else.
> So far this has not been a problem, since the Cirrus VGA was not linked
> into the sparc64 target. But with the upcoming Kconfig build system,
> all theoretically possible PCI cards will be enabled by default, so the
> Cirrus VGA card might become available on the sparc64 target, too. vl.c
> then picks the wrong card, causing sun4uv_init() to abort.
> Thus let's make it explicit that we always want stdvga for sparc64 and
> so set default_display = "std" for these machines.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/sparc64/sun4u.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
> index ff24d9b..399f2d7 100644
> --- a/hw/sparc64/sun4u.c
> +++ b/hw/sparc64/sun4u.c
> @@ -797,6 +797,7 @@ static void sun4u_class_init(ObjectClass *oc, void *data)
> mc->default_boot_order = "c";
> mc->default_cpu_type = SPARC_CPU_TYPE_NAME("TI-UltraSparc-IIi");
> mc->ignore_boot_device_suffixes = true;
> + mc->default_display = "std";
> fwc->get_dev_path = sun4u_fw_dev_path;
> }
>
> @@ -820,6 +821,7 @@ static void sun4v_class_init(ObjectClass *oc, void *data)
> mc->max_cpus = 1; /* XXX for now */
> mc->default_boot_order = "c";
> mc->default_cpu_type = SPARC_CPU_TYPE_NAME("Sun-UltraSparc-T1");
> + mc->default_display = "std";
> }
>
> static const TypeInfo sun4v_type = {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw/sparc64: Explicitly set default_display = "std"
2019-02-13 7:07 [Qemu-devel] [PATCH] hw/sparc64: Explicitly set default_display = "std" Thomas Huth
2019-02-13 11:22 ` Philippe Mathieu-Daudé
@ 2019-02-13 12:44 ` Mark Cave-Ayland
2019-02-14 10:03 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Mark Cave-Ayland @ 2019-02-13 12:44 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: Artyom Tarasenko, pbonzini, yang.zhong, philmd, qemu-trivial
On 13/02/2019 07:07, Thomas Huth wrote:
> The sun4uv_init() function expects vga_interface_type to be either
> VGA_STD or VGA_NONE and sets up a stdvga device or no vga card
> accordingly.
> However, the code in vl.c prefers the Cirrus VGA card to stdvga if
> it is available and the user and the machine did not specify anything
> else.
> So far this has not been a problem, since the Cirrus VGA was not linked
> into the sparc64 target. But with the upcoming Kconfig build system,
> all theoretically possible PCI cards will be enabled by default, so the
> Cirrus VGA card might become available on the sparc64 target, too. vl.c
> then picks the wrong card, causing sun4uv_init() to abort.
> Thus let's make it explicit that we always want stdvga for sparc64 and
> so set default_display = "std" for these machines.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/sparc64/sun4u.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
> index ff24d9b..399f2d7 100644
> --- a/hw/sparc64/sun4u.c
> +++ b/hw/sparc64/sun4u.c
> @@ -797,6 +797,7 @@ static void sun4u_class_init(ObjectClass *oc, void *data)
> mc->default_boot_order = "c";
> mc->default_cpu_type = SPARC_CPU_TYPE_NAME("TI-UltraSparc-IIi");
> mc->ignore_boot_device_suffixes = true;
> + mc->default_display = "std";
> fwc->get_dev_path = sun4u_fw_dev_path;
> }
>
> @@ -820,6 +821,7 @@ static void sun4v_class_init(ObjectClass *oc, void *data)
> mc->max_cpus = 1; /* XXX for now */
> mc->default_boot_order = "c";
> mc->default_cpu_type = SPARC_CPU_TYPE_NAME("Sun-UltraSparc-T1");
> + mc->default_display = "std";
> }
>
> static const TypeInfo sun4v_type = {
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/sparc64: Explicitly set default_display = "std"
2019-02-13 7:07 [Qemu-devel] [PATCH] hw/sparc64: Explicitly set default_display = "std" Thomas Huth
2019-02-13 11:22 ` Philippe Mathieu-Daudé
2019-02-13 12:44 ` Mark Cave-Ayland
@ 2019-02-14 10:03 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2019-02-14 10:03 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Mark Cave-Ayland
Cc: yang.zhong, pbonzini, qemu-trivial, philmd, Artyom Tarasenko
On 13/02/2019 08:07, Thomas Huth wrote:
> The sun4uv_init() function expects vga_interface_type to be either
> VGA_STD or VGA_NONE and sets up a stdvga device or no vga card
> accordingly.
> However, the code in vl.c prefers the Cirrus VGA card to stdvga if
> it is available and the user and the machine did not specify anything
> else.
> So far this has not been a problem, since the Cirrus VGA was not linked
> into the sparc64 target. But with the upcoming Kconfig build system,
> all theoretically possible PCI cards will be enabled by default, so the
> Cirrus VGA card might become available on the sparc64 target, too. vl.c
> then picks the wrong card, causing sun4uv_init() to abort.
> Thus let's make it explicit that we always want stdvga for sparc64 and
> so set default_display = "std" for these machines.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/sparc64/sun4u.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
> index ff24d9b..399f2d7 100644
> --- a/hw/sparc64/sun4u.c
> +++ b/hw/sparc64/sun4u.c
> @@ -797,6 +797,7 @@ static void sun4u_class_init(ObjectClass *oc, void *data)
> mc->default_boot_order = "c";
> mc->default_cpu_type = SPARC_CPU_TYPE_NAME("TI-UltraSparc-IIi");
> mc->ignore_boot_device_suffixes = true;
> + mc->default_display = "std";
> fwc->get_dev_path = sun4u_fw_dev_path;
> }
>
> @@ -820,6 +821,7 @@ static void sun4v_class_init(ObjectClass *oc, void *data)
> mc->max_cpus = 1; /* XXX for now */
> mc->default_boot_order = "c";
> mc->default_cpu_type = SPARC_CPU_TYPE_NAME("Sun-UltraSparc-T1");
> + mc->default_display = "std";
> }
>
> static const TypeInfo sun4v_type = {
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread