From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-block@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: [Qemu-devel] [PATCH] tests/qemu-iotests/235: Allow fallback to tcg and remove it from quick group
Date: Fri, 1 Mar 2019 13:20:29 +0100 [thread overview]
Message-ID: <1551442829-32359-1-git-send-email-thuth@redhat.com> (raw)
iotest 235 currently only works with KVM - this is bad for systems where
it is not available, e.g. CI pipelines. The test also works when using
"tcg" as accelerator, so we can simply add that to the list of accelerators,
too. But still, there might be the case that someone compiled their
QEMU with --disable-tcg and still try to run the iotests in a CI pipeline
where KVM is not available - in that case it would be best to use the
"qtest" accelerator for this test. However, that currently hangs and I
did not succeed to get it working with "accel=qtest" yet. Thus, as long
as this is not fixed, it's likely better to remove this test from the
"quick" group so that it does not fail on CI pipelines.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qemu-iotests/235 | 2 +-
tests/qemu-iotests/group | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/235 b/tests/qemu-iotests/235
index d6edd97..90ef785 100755
--- a/tests/qemu-iotests/235
+++ b/tests/qemu-iotests/235
@@ -49,7 +49,7 @@ qemu_img_create('-f', iotests.imgfmt, '-o', 'preallocation=metadata', disk,
str(size))
vm = QEMUMachine(iotests.qemu_prog)
-vm.add_args('-machine', 'accel=kvm')
+vm.add_args('-machine', 'accel=kvm:tcg')
if iotests.qemu_default_machine == 's390-ccw-virtio':
vm.add_args('-no-shutdown')
vm.add_args('-drive', 'id=src,file=' + disk)
diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
index b5ca63c..12ebeba 100644
--- a/tests/qemu-iotests/group
+++ b/tests/qemu-iotests/group
@@ -234,7 +234,7 @@
232 auto quick
233 auto quick
234 auto quick migration
-235 auto quick
+235 auto
236 auto quick
237 rw auto quick
238 auto quick
--
1.8.3.1
next reply other threads:[~2019-03-01 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 12:20 Thomas Huth [this message]
2019-03-01 13:15 ` [Qemu-devel] [PATCH] tests/qemu-iotests/235: Allow fallback to tcg and remove it from quick group Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551442829-32359-1-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).