From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL v2 16/31] build: remove unnecessary assignments from Makefile.target
Date: Mon, 11 Mar 2019 17:55:20 +0100 [thread overview]
Message-ID: <1552323335-46779-17-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1552323335-46779-1-git-send-email-pbonzini@redhat.com>
It is only necessary to clear block-obj-y because Makefile.objs
uses "+=" instead of "="; fix that and remove the assignment.
The other variables need not be cleared at all.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
Makefile.objs | 2 +-
Makefile.target | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/Makefile.objs b/Makefile.objs
index acc53aa..31a84b7 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -13,7 +13,7 @@ authz-obj-y = authz/
#######################################################################
# block-obj-y is code used by both qemu system emulation and qemu-img
-block-obj-y += nbd/
+block-obj-y = nbd/
block-obj-y += block.o blockjob.o job.o
block-obj-y += block/ scsi/
block-obj-y += qemu-io-cmds.o
diff --git a/Makefile.target b/Makefile.target
index a458506..441ace6 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -175,9 +175,6 @@ endif # CONFIG_SOFTMMU
dummy := $(call unnest-vars,,obj-y)
all-obj-y := $(obj-y)
-block-obj-y :=
-common-obj-y :=
-chardev-obj-y :=
include $(SRC_PATH)/Makefile.objs
dummy := $(call unnest-vars,.., \
authz-obj-y \
--
1.8.3.1
next prev parent reply other threads:[~2019-03-11 16:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 16:55 [Qemu-devel] [PULL v2 00/31] Misc patches for 2019-03-09 Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 01/31] memory: Do not update coalesced IO range in the case of NOP Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 02/31] vfio-pci: enable by default Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 03/31] riscv/Kconfig: enable PCI_DEVICES Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 04/31] tests: test-qgraph: fix a memory leak Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 05/31] hw/i386/pc: run the multiboot loader before the PVH loader Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 06/31] block/iscsi: Restrict Linux-specific code Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 07/31] contrib/elf2dmp: add kernel start address checking Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 08/31] configure: Enable werror for git worktrees Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 09/31] target-i386: add kvm stubs to user-mode emulators Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 10/31] i386: extended the cpuid_level when Intel PT is enabled Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 11/31] virtio-scsi: Fix build with gcc 9 Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 12/31] lsi: implement basic SBCL functionality Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 13/31] lsi: check if SIGP bit is already set in Wait reselect Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 14/31] update copyright notice Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 15/31] build: get rid of target-obj-y Paolo Bonzini
2019-03-11 16:55 ` Paolo Bonzini [this message]
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 17/31] build: clean trace/generated-helpers.c Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 18/31] accel: Allow to build QEMU without TCG or KVM support Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 19/31] oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 20/31] configure: Disable W^X on OpenBSD Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 21/31] scsi-disk: Fix crash if request is invaild or disk is no medium Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 22/31] lsi: use ldn_le_p()/stn_le_p() Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 23/31] lsi: use enum type for s->waiting Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 24/31] lsi: use enum type for s->msg_action Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 25/31] lsi: use SCSI phase names instead of numbers in trace Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 26/31] lsi: return dfifo value Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 27/31] lsi: 810/895A are always little endian Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 28/31] exec.c: refactor function flatview_add_to_dispatch() Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 29/31] qom: cpu: destroy work_mutex in cpu_common_finalize Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 30/31] chardev: add support for authorization for TLS clients Paolo Bonzini
2019-03-11 16:55 ` [Qemu-devel] [PULL v2 31/31] qemugdb: fix licensing Paolo Bonzini
2019-03-11 19:05 ` [Qemu-devel] [PULL v2 00/31] Misc patches for 2019-03-09 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552323335-46779-17-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).