qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: stefanha@redhat.com, fam@euphon.net, kwolf@redhat.com,
	mreitz@redhat.com, jsnow@redhat.com, berto@igalia.com,
	den@openvz.org, vsementsov@virtuozzo.com,
	andrey.shinkevich@virtuozzo.com
Subject: [Qemu-devel] [PATCH v4 0/3] block/stream: get rid of the base
Date: Mon,  8 Apr 2019 21:22:18 +0300	[thread overview]
Message-ID: <1554747741-918964-1-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)

This series introduces a bottom intermediate node that eliminates the
dependency on the base that may change while stream job is running.
It happens when stream/commit parallel jobs are running on the same
backing chain. The base node of the stream job may be a top node of
the parallel commit job and can change before the stream job is
completed. We avoid that dependency by introducing the bottom node.

v4:
trace_stream_start reverted to the base.
bdrv_is_allocated_above_inclusive() deleted and the new parameter
'bool include_base' was added to the bdrv_is_allocated_above().

v3:
bottom = bdrv_find_overlay() moved into the stream_start()

v2:
The function bdrv_find_overlay() with the same functionality has been
used in the qmp_block_stream() to find a bottom node.
The algorithm in the bdrv_do_is_allocated_above() was simplified.
The commit messages were modified.

Discussed in the e-mail threads with the message IDs
<1553866154-257311-1-git-send-email-andrey.shinkevich@virtuozzo.com>
<1550762799-830661-1-git-send-email-andrey.shinkevich@virtuozzo.com>
<1554120365-39119-1-git-send-email-andrey.shinkevich@virtuozzo.com>
<1554483379-682051-1-git-send-email-andrey.shinkevich@virtuozzo.com>

Andrey Shinkevich (2):
  block: include base when checking image chain for block allocation
  block/stream: introduce a bottom node

Vladimir Sementsov-Ogievskiy (1):
  block/stream: refactor stream_run: drop goto

 block/commit.c         |  2 +-
 block/io.c             | 14 +++++++++---
 block/mirror.c         |  2 +-
 block/replication.c    |  2 +-
 block/stream.c         | 62 +++++++++++++++++++++++---------------------------
 include/block/block.h  |  3 ++-
 tests/qemu-iotests/245 |  4 ++--
 7 files changed, 47 insertions(+), 42 deletions(-)

-- 
1.8.3.1

WARNING: multiple messages have this Message-ID (diff)
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com,
	berto@igalia.com, mreitz@redhat.com, stefanha@redhat.com,
	andrey.shinkevich@virtuozzo.com, den@openvz.org,
	jsnow@redhat.com
Subject: [Qemu-devel] [PATCH v4 0/3] block/stream: get rid of the base
Date: Mon,  8 Apr 2019 21:22:18 +0300	[thread overview]
Message-ID: <1554747741-918964-1-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)
Message-ID: <20190408182218.3omaYbGYJKVESHZxPgwKJkIOXC2ZVhU5bpR_ESAOPJg@z> (raw)

This series introduces a bottom intermediate node that eliminates the
dependency on the base that may change while stream job is running.
It happens when stream/commit parallel jobs are running on the same
backing chain. The base node of the stream job may be a top node of
the parallel commit job and can change before the stream job is
completed. We avoid that dependency by introducing the bottom node.

v4:
trace_stream_start reverted to the base.
bdrv_is_allocated_above_inclusive() deleted and the new parameter
'bool include_base' was added to the bdrv_is_allocated_above().

v3:
bottom = bdrv_find_overlay() moved into the stream_start()

v2:
The function bdrv_find_overlay() with the same functionality has been
used in the qmp_block_stream() to find a bottom node.
The algorithm in the bdrv_do_is_allocated_above() was simplified.
The commit messages were modified.

Discussed in the e-mail threads with the message IDs
<1553866154-257311-1-git-send-email-andrey.shinkevich@virtuozzo.com>
<1550762799-830661-1-git-send-email-andrey.shinkevich@virtuozzo.com>
<1554120365-39119-1-git-send-email-andrey.shinkevich@virtuozzo.com>
<1554483379-682051-1-git-send-email-andrey.shinkevich@virtuozzo.com>

Andrey Shinkevich (2):
  block: include base when checking image chain for block allocation
  block/stream: introduce a bottom node

Vladimir Sementsov-Ogievskiy (1):
  block/stream: refactor stream_run: drop goto

 block/commit.c         |  2 +-
 block/io.c             | 14 +++++++++---
 block/mirror.c         |  2 +-
 block/replication.c    |  2 +-
 block/stream.c         | 62 +++++++++++++++++++++++---------------------------
 include/block/block.h  |  3 ++-
 tests/qemu-iotests/245 |  4 ++--
 7 files changed, 47 insertions(+), 42 deletions(-)

-- 
1.8.3.1



             reply	other threads:[~2019-04-08 18:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 18:22 Andrey Shinkevich [this message]
2019-04-08 18:22 ` [Qemu-devel] [PATCH v4 0/3] block/stream: get rid of the base Andrey Shinkevich
2019-04-08 18:22 ` [Qemu-devel] [PATCH v4 1/3] block: include base when checking image chain for block allocation Andrey Shinkevich
2019-04-08 18:22   ` Andrey Shinkevich
2019-04-09  8:57   ` Vladimir Sementsov-Ogievskiy
2019-04-09  8:57     ` Vladimir Sementsov-Ogievskiy
2019-04-09 14:18   ` Alberto Garcia
2019-04-09 14:18     ` Alberto Garcia
2019-04-09 14:43     ` Vladimir Sementsov-Ogievskiy
2019-04-09 14:43       ` Vladimir Sementsov-Ogievskiy
2019-04-09 14:48       ` Alberto Garcia
2019-04-09 14:48         ` Alberto Garcia
2019-04-08 18:22 ` [Qemu-devel] [PATCH v4 2/3] block/stream: refactor stream_run: drop goto Andrey Shinkevich
2019-04-08 18:22   ` Andrey Shinkevich
2019-04-08 18:22 ` [Qemu-devel] [PATCH v4 3/3] block/stream: introduce a bottom node Andrey Shinkevich
2019-04-08 18:22   ` Andrey Shinkevich
2019-04-09  8:58   ` Vladimir Sementsov-Ogievskiy
2019-04-09  8:58     ` Vladimir Sementsov-Ogievskiy
2019-04-09 13:16   ` Alberto Garcia
2019-04-09 13:16     ` Alberto Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1554747741-918964-1-git-send-email-andrey.shinkevich@virtuozzo.com \
    --to=andrey.shinkevich@virtuozzo.com \
    --cc=berto@igalia.com \
    --cc=den@openvz.org \
    --cc=fam@euphon.net \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).