From: Yi Wang <wang.yi59@zte.com.cn> To: quintela@redhat.com Cc: dgilbert@redhat.com, qemu-devel@nongnu.org, Yi Wang <wang.yi59@zte.com.cn> Subject: [Qemu-devel] [PATCH] migration: update comments of migration bitmap Date: Mon, 15 Apr 2019 14:51:29 +0800 [thread overview] Message-ID: <1555311089-18610-1-git-send-email-wang.yi59@zte.com.cn> (raw) Since the ram bitmap and the unsent bitmap are split by RAMBlock in commit 6b6712e, it's better to update the comments about them. Signed-off-by: Yi Wang <wang.yi59@zte.com.cn> --- migration/ram.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 1ca9ba7..24ab23d 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1630,8 +1630,6 @@ static int save_xbzrle_page(RAMState *rs, uint8_t **current_data, /** * migration_bitmap_find_dirty: find the next dirty page from start * - * Called with rcu_read_lock() to protect migration_bitmap - * * Returns the byte offset within memory region of the start of a dirty page * * @rs: current RAM state @@ -2681,7 +2679,7 @@ static void ram_save_cleanup(void *opaque) RAMBlock *block; /* caller have hold iothread lock or is in a bh, so there is - * no writing race against this migration_bitmap + * no writing race against the migration bitmap */ memory_global_dirty_log_stop(); -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Yi Wang <wang.yi59@zte.com.cn> To: quintela@redhat.com Cc: Yi Wang <wang.yi59@zte.com.cn>, dgilbert@redhat.com, qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] migration: update comments of migration bitmap Date: Mon, 15 Apr 2019 14:51:29 +0800 [thread overview] Message-ID: <1555311089-18610-1-git-send-email-wang.yi59@zte.com.cn> (raw) Message-ID: <20190415065129.lTUdssWKAarnJZWTzXijUD5IzBqVlIjt8pu9npOkmf4@z> (raw) Since the ram bitmap and the unsent bitmap are split by RAMBlock in commit 6b6712e, it's better to update the comments about them. Signed-off-by: Yi Wang <wang.yi59@zte.com.cn> --- migration/ram.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 1ca9ba7..24ab23d 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1630,8 +1630,6 @@ static int save_xbzrle_page(RAMState *rs, uint8_t **current_data, /** * migration_bitmap_find_dirty: find the next dirty page from start * - * Called with rcu_read_lock() to protect migration_bitmap - * * Returns the byte offset within memory region of the start of a dirty page * * @rs: current RAM state @@ -2681,7 +2679,7 @@ static void ram_save_cleanup(void *opaque) RAMBlock *block; /* caller have hold iothread lock or is in a bh, so there is - * no writing race against this migration_bitmap + * no writing race against the migration bitmap */ memory_global_dirty_log_stop(); -- 1.8.3.1
next reply other threads:[~2019-04-15 6:51 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-15 6:51 Yi Wang [this message] 2019-04-15 6:51 ` [Qemu-devel] [PATCH] migration: update comments of migration bitmap Yi Wang 2019-05-14 14:34 ` Dr. David Alan Gilbert 2019-05-14 14:35 ` Dr. David Alan Gilbert
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1555311089-18610-1-git-send-email-wang.yi59@zte.com.cn \ --to=wang.yi59@zte.com.cn \ --cc=dgilbert@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=quintela@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).