* [Qemu-devel] [PATCH] migration: update comments of migration bitmap
@ 2019-04-15 6:51 Yi Wang
2019-04-15 6:51 ` Yi Wang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yi Wang @ 2019-04-15 6:51 UTC (permalink / raw)
To: quintela; +Cc: dgilbert, qemu-devel, Yi Wang
Since the ram bitmap and the unsent bitmap are split by RAMBlock
in commit 6b6712e, it's better to update the comments about them.
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
migration/ram.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 1ca9ba7..24ab23d 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1630,8 +1630,6 @@ static int save_xbzrle_page(RAMState *rs, uint8_t **current_data,
/**
* migration_bitmap_find_dirty: find the next dirty page from start
*
- * Called with rcu_read_lock() to protect migration_bitmap
- *
* Returns the byte offset within memory region of the start of a dirty page
*
* @rs: current RAM state
@@ -2681,7 +2679,7 @@ static void ram_save_cleanup(void *opaque)
RAMBlock *block;
/* caller have hold iothread lock or is in a bh, so there is
- * no writing race against this migration_bitmap
+ * no writing race against the migration bitmap
*/
memory_global_dirty_log_stop();
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] migration: update comments of migration bitmap
2019-04-15 6:51 [Qemu-devel] [PATCH] migration: update comments of migration bitmap Yi Wang
@ 2019-04-15 6:51 ` Yi Wang
2019-05-14 14:34 ` Dr. David Alan Gilbert
2019-05-14 14:35 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Yi Wang @ 2019-04-15 6:51 UTC (permalink / raw)
To: quintela; +Cc: Yi Wang, dgilbert, qemu-devel
Since the ram bitmap and the unsent bitmap are split by RAMBlock
in commit 6b6712e, it's better to update the comments about them.
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
migration/ram.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 1ca9ba7..24ab23d 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1630,8 +1630,6 @@ static int save_xbzrle_page(RAMState *rs, uint8_t **current_data,
/**
* migration_bitmap_find_dirty: find the next dirty page from start
*
- * Called with rcu_read_lock() to protect migration_bitmap
- *
* Returns the byte offset within memory region of the start of a dirty page
*
* @rs: current RAM state
@@ -2681,7 +2679,7 @@ static void ram_save_cleanup(void *opaque)
RAMBlock *block;
/* caller have hold iothread lock or is in a bh, so there is
- * no writing race against this migration_bitmap
+ * no writing race against the migration bitmap
*/
memory_global_dirty_log_stop();
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration: update comments of migration bitmap
2019-04-15 6:51 [Qemu-devel] [PATCH] migration: update comments of migration bitmap Yi Wang
2019-04-15 6:51 ` Yi Wang
@ 2019-05-14 14:34 ` Dr. David Alan Gilbert
2019-05-14 14:35 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2019-05-14 14:34 UTC (permalink / raw)
To: Yi Wang; +Cc: qemu-devel, quintela
* Yi Wang (wang.yi59@zte.com.cn) wrote:
> Since the ram bitmap and the unsent bitmap are split by RAMBlock
> in commit 6b6712e, it's better to update the comments about them.
>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/ram.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 1ca9ba7..24ab23d 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -1630,8 +1630,6 @@ static int save_xbzrle_page(RAMState *rs, uint8_t **current_data,
> /**
> * migration_bitmap_find_dirty: find the next dirty page from start
> *
> - * Called with rcu_read_lock() to protect migration_bitmap
> - *
> * Returns the byte offset within memory region of the start of a dirty page
> *
> * @rs: current RAM state
> @@ -2681,7 +2679,7 @@ static void ram_save_cleanup(void *opaque)
> RAMBlock *block;
>
> /* caller have hold iothread lock or is in a bh, so there is
> - * no writing race against this migration_bitmap
> + * no writing race against the migration bitmap
> */
> memory_global_dirty_log_stop();
>
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: update comments of migration bitmap
2019-04-15 6:51 [Qemu-devel] [PATCH] migration: update comments of migration bitmap Yi Wang
2019-04-15 6:51 ` Yi Wang
2019-05-14 14:34 ` Dr. David Alan Gilbert
@ 2019-05-14 14:35 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2019-05-14 14:35 UTC (permalink / raw)
To: Yi Wang; +Cc: qemu-devel, quintela
* Yi Wang (wang.yi59@zte.com.cn) wrote:
> Since the ram bitmap and the unsent bitmap are split by RAMBlock
> in commit 6b6712e, it's better to update the comments about them.
>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Queued
> ---
> migration/ram.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 1ca9ba7..24ab23d 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -1630,8 +1630,6 @@ static int save_xbzrle_page(RAMState *rs, uint8_t **current_data,
> /**
> * migration_bitmap_find_dirty: find the next dirty page from start
> *
> - * Called with rcu_read_lock() to protect migration_bitmap
> - *
> * Returns the byte offset within memory region of the start of a dirty page
> *
> * @rs: current RAM state
> @@ -2681,7 +2679,7 @@ static void ram_save_cleanup(void *opaque)
> RAMBlock *block;
>
> /* caller have hold iothread lock or is in a bh, so there is
> - * no writing race against this migration_bitmap
> + * no writing race against the migration bitmap
> */
> memory_global_dirty_log_stop();
>
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-14 14:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-15 6:51 [Qemu-devel] [PATCH] migration: update comments of migration bitmap Yi Wang
2019-04-15 6:51 ` Yi Wang
2019-05-14 14:34 ` Dr. David Alan Gilbert
2019-05-14 14:35 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).