From: Igor Mammedov <imammedo@redhat.com> To: qemu-devel@nongnu.org Cc: "Paolo Bonzini" <pbonzini@redhat.com>, "Richard Henderson" <rth@twiddle.net>, "Helge Deller" <deller@gmx.de>, "Hervé Poussineau" <hpoussin@reactos.org>, "David Gibson" <david@gibson.dropbear.id.au>, "Cornelia Huck" <cohuck@redhat.com>, "Halil Pasic" <pasic@linux.ibm.com>, "Christian Borntraeger" <borntraeger@de.ibm.com>, "David Hildenbrand" <david@redhat.com>, "Artyom Tarasenko" <atar4qemu@gmail.com>, "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org Subject: [Qemu-devel] [PATCH v1 4/5] memory: make MemoryRegion alias migratable Date: Mon, 15 Apr 2019 15:27:21 +0200 [thread overview] Message-ID: <1555334842-195718-5-git-send-email-imammedo@redhat.com> (raw) In-Reply-To: <1555334842-195718-1-git-send-email-imammedo@redhat.com> use qemu_ram_alloc_from_ptr() to create aliased RAMBlock to the part of original memory region. Signed-off-by: Igor Mammedov <imammedo@redhat.com> --- exec.c | 7 ++++--- memory.c | 5 +++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 6ab62f4..0fc10d1 100644 --- a/exec.c +++ b/exec.c @@ -2255,7 +2255,7 @@ static void ram_block_add(RAMBlock *new_block, Error **errp, bool shared) new_block->used_length, DIRTY_CLIENTS_ALL); - if (new_block->host) { + if (new_block->host && !new_block->mr->alias) { qemu_ram_setup_dump(new_block->host, new_block->max_length); qemu_madvise(new_block->host, new_block->max_length, QEMU_MADV_HUGEPAGE); /* MADV_DONTFORK is also needed by KVM in absence of synchronous MMU */ @@ -2613,7 +2613,8 @@ RAMBlock *qemu_ram_block_from_host(void *ptr, bool round_offset, rcu_read_lock(); block = atomic_rcu_read(&ram_list.mru_block); - if (block && block->host && host - block->host < block->max_length) { + if (block && !block->mr->alias && block->host && + host - block->host < block->max_length) { goto found; } @@ -2622,7 +2623,7 @@ RAMBlock *qemu_ram_block_from_host(void *ptr, bool round_offset, if (block->host == NULL) { continue; } - if (host - block->host < block->max_length) { + if (!block->mr->alias && host - block->host < block->max_length) { goto found; } } diff --git a/memory.c b/memory.c index 9fbca52..687a147 100644 --- a/memory.c +++ b/memory.c @@ -1672,6 +1672,11 @@ void memory_region_init_alias(MemoryRegion *mr, memory_region_init(mr, owner, name, size); mr->alias = orig; mr->alias_offset = offset; + if (orig->ram_block && size) { + mr->ram_block = qemu_ram_alloc_from_ptr(size, + orig->ram_block->host + offset, + mr, &error_fatal); + } } void memory_region_init_rom_nomigrate(MemoryRegion *mr, -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Igor Mammedov <imammedo@redhat.com> To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, "David Hildenbrand" <david@redhat.com>, "Helge Deller" <deller@gmx.de>, "Cornelia Huck" <cohuck@redhat.com>, "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>, "Halil Pasic" <pasic@linux.ibm.com>, "Christian Borntraeger" <borntraeger@de.ibm.com>, qemu-s390x@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>, "Paolo Bonzini" <pbonzini@redhat.com>, "Richard Henderson" <rth@twiddle.net>, "Artyom Tarasenko" <atar4qemu@gmail.com>, "David Gibson" <david@gibson.dropbear.id.au> Subject: [Qemu-devel] [PATCH v1 4/5] memory: make MemoryRegion alias migratable Date: Mon, 15 Apr 2019 15:27:21 +0200 [thread overview] Message-ID: <1555334842-195718-5-git-send-email-imammedo@redhat.com> (raw) Message-ID: <20190415132721.w7O3c9YMwm58aPSsueW1XIZOUJrppt8IHa3jZvKjOAY@z> (raw) In-Reply-To: <1555334842-195718-1-git-send-email-imammedo@redhat.com> use qemu_ram_alloc_from_ptr() to create aliased RAMBlock to the part of original memory region. Signed-off-by: Igor Mammedov <imammedo@redhat.com> --- exec.c | 7 ++++--- memory.c | 5 +++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 6ab62f4..0fc10d1 100644 --- a/exec.c +++ b/exec.c @@ -2255,7 +2255,7 @@ static void ram_block_add(RAMBlock *new_block, Error **errp, bool shared) new_block->used_length, DIRTY_CLIENTS_ALL); - if (new_block->host) { + if (new_block->host && !new_block->mr->alias) { qemu_ram_setup_dump(new_block->host, new_block->max_length); qemu_madvise(new_block->host, new_block->max_length, QEMU_MADV_HUGEPAGE); /* MADV_DONTFORK is also needed by KVM in absence of synchronous MMU */ @@ -2613,7 +2613,8 @@ RAMBlock *qemu_ram_block_from_host(void *ptr, bool round_offset, rcu_read_lock(); block = atomic_rcu_read(&ram_list.mru_block); - if (block && block->host && host - block->host < block->max_length) { + if (block && !block->mr->alias && block->host && + host - block->host < block->max_length) { goto found; } @@ -2622,7 +2623,7 @@ RAMBlock *qemu_ram_block_from_host(void *ptr, bool round_offset, if (block->host == NULL) { continue; } - if (host - block->host < block->max_length) { + if (!block->mr->alias && host - block->host < block->max_length) { goto found; } } diff --git a/memory.c b/memory.c index 9fbca52..687a147 100644 --- a/memory.c +++ b/memory.c @@ -1672,6 +1672,11 @@ void memory_region_init_alias(MemoryRegion *mr, memory_region_init(mr, owner, name, size); mr->alias = orig; mr->alias_offset = offset; + if (orig->ram_block && size) { + mr->ram_block = qemu_ram_alloc_from_ptr(size, + orig->ram_block->host + offset, + mr, &error_fatal); + } } void memory_region_init_rom_nomigrate(MemoryRegion *mr, -- 2.7.4
next prev parent reply other threads:[~2019-04-15 13:27 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-15 13:27 [Qemu-devel] [PATCH v1 0/5] Fix misuses of memory_region_allocate_system_memory() Igor Mammedov 2019-04-15 13:27 ` Igor Mammedov 2019-04-15 13:27 ` [Qemu-devel] [PATCH v1 1/5] sparc64: use memory_region_allocate_system_memory() only for '-m' specified RAM Igor Mammedov 2019-04-15 13:27 ` Igor Mammedov 2019-04-15 15:07 ` Philippe Mathieu-Daudé 2019-04-15 15:07 ` Philippe Mathieu-Daudé 2019-04-15 13:27 ` [Qemu-devel] [PATCH v1 2/5] ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory() Igor Mammedov 2019-04-15 13:27 ` Igor Mammedov 2019-04-16 4:13 ` David Gibson 2019-04-16 4:13 ` David Gibson 2019-04-15 13:27 ` [Qemu-devel] [PATCH v1 3/5] hppa: drop usage of memory_region_allocate_system_memory() for ROM Igor Mammedov 2019-04-15 13:27 ` Igor Mammedov 2019-04-15 15:16 ` Philippe Mathieu-Daudé 2019-04-15 15:16 ` Philippe Mathieu-Daudé 2019-04-15 13:27 ` Igor Mammedov [this message] 2019-04-15 13:27 ` [Qemu-devel] [PATCH v1 4/5] memory: make MemoryRegion alias migratable Igor Mammedov 2019-04-15 13:27 ` [Qemu-devel] [PATCH v1 5/5] s390: do not call memory_region_allocate_system_memory() multiple times Igor Mammedov 2019-04-15 13:27 ` Igor Mammedov 2019-04-16 11:01 ` Christian Borntraeger 2019-04-16 11:01 ` Christian Borntraeger 2019-04-16 11:02 ` Christian Borntraeger 2019-04-16 11:02 ` Christian Borntraeger 2019-04-16 11:09 ` Christian Borntraeger 2019-04-16 11:09 ` Christian Borntraeger 2019-04-17 14:30 ` Igor Mammedov 2019-04-17 14:30 ` Igor Mammedov 2019-04-18 9:38 ` Igor Mammedov 2019-04-18 9:38 ` Igor Mammedov 2019-04-18 11:24 ` David Hildenbrand 2019-04-18 11:24 ` David Hildenbrand 2019-04-18 12:01 ` Igor Mammedov 2019-04-18 12:01 ` Igor Mammedov 2019-04-18 12:06 ` David Hildenbrand 2019-04-18 12:06 ` David Hildenbrand 2019-04-18 14:56 ` Igor Mammedov 2019-04-18 14:56 ` Igor Mammedov 2019-04-18 15:01 ` David Hildenbrand 2019-04-18 15:01 ` David Hildenbrand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1555334842-195718-5-git-send-email-imammedo@redhat.com \ --to=imammedo@redhat.com \ --cc=atar4qemu@gmail.com \ --cc=borntraeger@de.ibm.com \ --cc=cohuck@redhat.com \ --cc=david@gibson.dropbear.id.au \ --cc=david@redhat.com \ --cc=deller@gmx.de \ --cc=hpoussin@reactos.org \ --cc=mark.cave-ayland@ilande.co.uk \ --cc=pasic@linux.ibm.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-ppc@nongnu.org \ --cc=qemu-s390x@nongnu.org \ --cc=rth@twiddle.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).