Re: [Qemu-devel] [PATCH v6 00/11] vhost-user for input & GPU

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20190423132004.13725-1-marcandre.lureau@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190423132004.13725-1-marcandre.lureau@redhat.com
Subject: [Qemu-devel] [PATCH v6 00/11] vhost-user for input & GPU

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dae2bdda06 hw/display: add vhost-user-vga & gpu-pci
5085d87320 virtio-gpu: split virtio-gpu-pci & virtio-vga
4b0acd3384 virtio-gpu: split virtio-gpu, introduce virtio-gpu-base
c1d833191f contrib: add vhost-user-gpu
cba97fa704 util: compile drm.o on Linux
b7f05f9505 virtio: add virtio-gpu bswap helpers header
567cb03399 vhost-user: add vhost_user_gpu_set_socket()
e42b84bcb3 contrib: add vhost-user-input
455270bf34 libvhost-user: add PROTOCOL_F_CONFIG if {set, get}_config
4cce0394b0 Add vhost-user-input-pci
34a8518660 Add vhost-user-backend

=== OUTPUT BEGIN ===
1/11 Checking commit 34a851866041 (Add vhost-user-backend)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#143: FILE: backends/vhost-user.c:95:
+    /* guest_notifier_mask/pending not used yet, so just unmask

total: 0 errors, 2 warnings, 280 lines checked

Patch 1/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/11 Checking commit 4cce0394b02c (Add vhost-user-input-pci)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#58: 
new file mode 100644

total: 0 errors, 1 warnings, 250 lines checked

Patch 2/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/11 Checking commit 455270bf3492 (libvhost-user: add PROTOCOL_F_CONFIG if {set, get}_config)
4/11 Checking commit e42b84bcb3fc (contrib: add vhost-user-input)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 458 lines checked

Patch 4/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/11 Checking commit 567cb0339958 (vhost-user: add vhost_user_gpu_set_socket())
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

total: 0 errors, 1 warnings, 313 lines checked

Patch 5/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/11 Checking commit b7f05f95058d (virtio: add virtio-gpu bswap helpers header)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

total: 0 errors, 1 warnings, 116 lines checked

Patch 6/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/11 Checking commit cba97fa704c1 (util: compile drm.o on Linux)
8/11 Checking commit c1d833191f34 (contrib: add vhost-user-gpu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#164: 
new file mode 100644

total: 0 errors, 1 warnings, 2573 lines checked

Patch 8/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/11 Checking commit 4b0acd33848a (virtio-gpu: split virtio-gpu, introduce virtio-gpu-base)
WARNING: Block comments use a leading /* on a separate line
#100: FILE: hw/display/virtio-gpu-3d.c:181:
+            info.flags & 1 /* FIXME: Y_0_TOP */,

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#188: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#1253: FILE: include/hw/virtio/virtio-gpu.h:122:
+#define VIRTIO_GPU_BASE_PROPERTIES(_state, _conf)                       \
+    DEFINE_PROP_UINT32("max_outputs", _state, _conf.max_outputs, 1),    \
+    DEFINE_PROP_BIT("edid", _state, _conf.flags, \
+                    VIRTIO_GPU_FLAG_EDID_ENABLED, false), \
+    DEFINE_PROP_UINT32("xres", _state, _conf.xres, 1024), \
+    DEFINE_PROP_UINT32("yres", _state, _conf.yres, 768)

total: 1 errors, 2 warnings, 1184 lines checked

Patch 9/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/11 Checking commit 5085d87320e8 (virtio-gpu: split virtio-gpu-pci & virtio-vga)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#392: 
new file mode 100644

total: 0 errors, 1 warnings, 390 lines checked

Patch 10/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/11 Checking commit dae2bdda06e1 (hw/display: add vhost-user-vga & gpu-pci)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#829: FILE: include/hw/virtio/virtio-gpu-pci.h:35:
+#define DEFINE_VIRTIO_GPU_PCI_PROPERTIES(_state)                \
+    DEFINE_PROP_BIT("ioeventfd", _state, flags,                 \
+                    VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, false),  \
+        DEFINE_PROP_UINT32("vectors", _state, nvectors, 3)

total: 1 errors, 1 warnings, 818 lines checked

Patch 11/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190423132004.13725-1-marcandre.lureau@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com