Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20190423212246.3542-1-ehabkost@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190423212246.3542-1-ehabkost@redhat.com
Subject: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190416125744.27770-1-peter.maydell@linaro.org -> patchew/20190416125744.27770-1-peter.maydell@linaro.org
 t [tag update]            patchew/20190418113110.160664-1-borntraeger@de.ibm.com -> patchew/20190418113110.160664-1-borntraeger@de.ibm.com
 t [tag update]            patchew/20190420073442.7488-1-richard.henderson@linaro.org -> patchew/20190420073442.7488-1-richard.henderson@linaro.org
 t [tag update]            patchew/20190422195020.1494-1-philmd@redhat.com -> patchew/20190422195020.1494-1-philmd@redhat.com
 t [tag update]            patchew/20190422221714.7630-1-jsnow@redhat.com -> patchew/20190422221714.7630-1-jsnow@redhat.com
 t [tag update]            patchew/20190423160608.7519-1-thuth@redhat.com -> patchew/20190423160608.7519-1-thuth@redhat.com
 * [new tag]               patchew/20190423212246.3542-1-ehabkost@redhat.com -> patchew/20190423212246.3542-1-ehabkost@redhat.com
Switched to a new branch 'test'
29e2716a80 qmp: Add deprecation information to query-machines
34cb9a3b70 machine: Use SupportStatusInfo for deprecation info
b44b7a4718 qapi: SupportStatusInfo struct

=== OUTPUT BEGIN ===
1/3 Checking commit b44b7a47188e (qapi: SupportStatusInfo struct)
2/3 Checking commit 34cb9a3b7083 (machine: Use SupportStatusInfo for deprecation info)
3/3 Checking commit 29e2716a80c8 (qmp: Add deprecation information to query-machines)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

ERROR: line over 90 characters
#65: FILE: tests/acceptance/query_machines.py:24:
+                                "Deprecated machine (%s) must have status-message or suggested-alternative" % (machine['name']))

ERROR: line over 90 characters
#68: FILE: tests/acceptance/query_machines.py:27:
+                                "suggested-alternative of %s must point to a valid machine type" % (machine['name']))

total: 2 errors, 1 warnings, 55 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190423212246.3542-1-ehabkost@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com