qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Like Xu <like.xu@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alistair Francis" <alistair23@gmail.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v2 01/10] hw/boards: add struct CpuTopology to MachineState
Date: Mon,  6 May 2019 16:33:07 +0800	[thread overview]
Message-ID: <1557131596-25403-2-git-send-email-like.xu@linux.intel.com> (raw)
In-Reply-To: <1557131596-25403-1-git-send-email-like.xu@linux.intel.com>

To remove usages of global smp variables arch by arch,
a bisect friendly way is introduced to initialize struct
CpuTopology with duplicate ones; no semantic changes.

Suggested-by: Igor Mammedov <imammedo@redhat.com>
Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Like Xu <like.xu@linux.intel.com>
---
 include/hw/boards.h | 15 +++++++++++++++
 vl.c                |  5 +++++
 2 files changed, 20 insertions(+)

diff --git a/include/hw/boards.h b/include/hw/boards.h
index 6f7916f..dc89c6d 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -231,6 +231,20 @@ typedef struct DeviceMemoryState {
 } DeviceMemoryState;
 
 /**
+ * CpuTopology:
+ * @cpus: the number of logical processors on the machine
+ * @cores: the number of cores in one package
+ * @threads: the number of threads in one core
+ * @max_cpus: the maximum number of logical processors on the machine
+ */
+typedef struct CpuTopology {
+    unsigned int cpus;
+    unsigned int cores;
+    unsigned int threads;
+    unsigned int max_cpus;
+} CpuTopology;
+
+/**
  * MachineState:
  */
 struct MachineState {
@@ -272,6 +286,7 @@ struct MachineState {
     const char *cpu_type;
     AccelState *accelerator;
     CPUArchIdList *possible_cpus;
+    CpuTopology smp;
     struct NVDIMMState *nvdimms_state;
 };
 
diff --git a/vl.c b/vl.c
index d9fea0a..43fd247 100644
--- a/vl.c
+++ b/vl.c
@@ -4099,6 +4099,11 @@ int main(int argc, char **argv, char **envp)
 
     smp_parse(qemu_opts_find(qemu_find_opts("smp-opts"), NULL));
 
+    current_machine->smp.cpus = smp_cpus;
+    current_machine->smp.max_cpus = max_cpus;
+    current_machine->smp.cores = smp_cores;
+    current_machine->smp.threads = smp_threads;
+
     /* sanity-check smp_cpus and max_cpus against machine_class */
     if (smp_cpus < machine_class->min_cpus) {
         error_report("Invalid SMP CPUs %d. The min CPUs "
-- 
1.8.3.1



  reply	other threads:[~2019-05-06  8:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06  8:33 [Qemu-devel] [PATCH v2 00/10] refactor cpu topo into machine properties Like Xu
2019-05-06  8:33 ` Like Xu [this message]
2019-05-09 16:32   ` [Qemu-devel] [PATCH v2 01/10] hw/boards: add struct CpuTopology to MachineState Alistair Francis
2019-05-17  8:46   ` Igor Mammedov
2019-05-06  8:33 ` [Qemu-devel] [PATCH v2 02/10] cpu/topology: related call chains refactoring to pass MachineState Like Xu
2019-05-09 16:34   ` Alistair Francis
2019-05-17  9:00   ` Igor Mammedov
2019-05-06  8:33 ` [Qemu-devel] [PATCH v2 03/10] cpu/topology: replace global smp variables by MachineState in general path Like Xu
2019-05-09 16:36   ` Alistair Francis
2019-05-17  9:08   ` Igor Mammedov
2019-05-06  8:33 ` [Qemu-devel] [PATCH v2 04/10] cpu/topology: add uncommon arch support for smp machine properties Like Xu
2019-05-09 16:37   ` Alistair Francis
2019-05-17  9:17   ` Igor Mammedov
2019-05-06  8:33 ` [Qemu-devel] [PATCH v2 05/10] cpu/topology: add hw/ppc " Like Xu
2019-05-17  9:20   ` Igor Mammedov
2019-05-06  8:33 ` [Qemu-devel] [PATCH v2 06/10] cpu/topology: add hw/riscv " Like Xu
2019-05-06  8:33 ` [Qemu-devel] [PATCH v2 07/10] cpu/topology: add hw/s390x " Like Xu
2019-05-06  8:33 ` [Qemu-devel] [PATCH v2 08/10] cpu/topology: add hw/i386 " Like Xu
2019-05-06  8:33 ` [Qemu-devel] [PATCH v2 09/10] cpu/topology: add hw/arm " Like Xu
2019-05-09 16:46   ` Alistair Francis
2019-05-06  8:33 ` [Qemu-devel] [PATCH v2 10/10] cpu/topology: replace smp global variables with " Like Xu
2019-05-09 16:48   ` Alistair Francis
2019-05-10  0:55 ` [Qemu-devel] [PATCH v2 00/10] refactor cpu topo into " Like Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1557131596-25403-2-git-send-email-like.xu@linux.intel.com \
    --to=like.xu@linux.intel.com \
    --cc=alex.bennee@linaro.org \
    --cc=alistair23@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).