qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, thuth@redhat.com, berrange@redhat.com,
	mst@redhat.com, armbru@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v2] docs: smbios: remove family=x from type2 entry description
Date: Tue, 21 May 2019 16:23:31 +0200	[thread overview]
Message-ID: <1558448611-315074-1-git-send-email-imammedo@redhat.com> (raw)

'family' option is not part of type 2 table and if user tries to use it
as such QEMU will error out with an unknow option error.
Drop it from docs lest it confuse users.

Fixes: b155eb1d04 ("smbios: document cmdline options for smbios type 2-4, 17 structures")
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 v2:
  - add summary to "Fixes:" in addition to commit message

 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 5daa5a8..dcdb808 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2080,7 +2080,7 @@ Specify SMBIOS type 0 fields
 @item -smbios type=1[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,uuid=@var{uuid}][,sku=@var{str}][,family=@var{str}]
 Specify SMBIOS type 1 fields
 
-@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}][,family=@var{str}]
+@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}]
 Specify SMBIOS type 2 fields
 
 @item -smbios type=3[,manufacturer=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,sku=@var{str}]
-- 
2.7.4



WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL 07/10] docs: smbios: remove family=x from type2 entry description
Date: Wed, 29 May 2019 12:37:28 -0400	[thread overview]
Message-ID: <1558448611-315074-1-git-send-email-imammedo@redhat.com> (raw)
Message-ID: <20190529163728.GsP7FP24MXD2WcPTwthfOEyEFbWZb8wuJXCQ-XrJbXc@z> (raw)
In-Reply-To: <20190529163604.18560-1-mst@redhat.com>

From: Igor Mammedov <imammedo@redhat.com>

'family' option is not part of type 2 table and if user tries to use it
as such QEMU will error out with an unknow option error.
Drop it from docs lest it confuse users.

Fixes: b155eb1d04 ("smbios: document cmdline options for smbios type 2-4, 17 structures")
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <1558448611-315074-1-git-send-email-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 39dc170429..0d8beb4afd 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2080,7 +2080,7 @@ Specify SMBIOS type 0 fields
 @item -smbios type=1[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,uuid=@var{uuid}][,sku=@var{str}][,family=@var{str}]
 Specify SMBIOS type 1 fields
 
-@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}][,family=@var{str}]
+@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}]
 Specify SMBIOS type 2 fields
 
 @item -smbios type=3[,manufacturer=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,sku=@var{str}]
-- 
MST



WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL v2 06/14] docs: smbios: remove family=x from type2 entry description
Date: Mon, 3 Jun 2019 14:08:45 -0400	[thread overview]
Message-ID: <1558448611-315074-1-git-send-email-imammedo@redhat.com> (raw)
Message-ID: <20190603180845.XFYAT-jWkHHZnAjRHVurPre6Q6yIMsrFqggPlJRELdI@z> (raw)
In-Reply-To: <20190603180807.16140-1-mst@redhat.com>

From: Igor Mammedov <imammedo@redhat.com>

'family' option is not part of type 2 table and if user tries to use it
as such QEMU will error out with an unknow option error.
Drop it from docs lest it confuse users.

Fixes: b155eb1d04 ("smbios: document cmdline options for smbios type 2-4, 17 structures")
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <1558448611-315074-1-git-send-email-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 39dc170429..0d8beb4afd 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2080,7 +2080,7 @@ Specify SMBIOS type 0 fields
 @item -smbios type=1[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,uuid=@var{uuid}][,sku=@var{str}][,family=@var{str}]
 Specify SMBIOS type 1 fields
 
-@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}][,family=@var{str}]
+@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}]
 Specify SMBIOS type 2 fields
 
 @item -smbios type=3[,manufacturer=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,sku=@var{str}]
-- 
MST



WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL v3 06/17] docs: smbios: remove family=x from type2 entry description
Date: Wed, 5 Jun 2019 16:00:18 -0400	[thread overview]
Message-ID: <1558448611-315074-1-git-send-email-imammedo@redhat.com> (raw)
Message-ID: <20190605200018.MzQcs6rFHTX2mHcP67NbvwSPxv6VUsGDA9Lc39ceByI@z> (raw)
In-Reply-To: <20190605195913.12243-1-mst@redhat.com>

From: Igor Mammedov <imammedo@redhat.com>

'family' option is not part of type 2 table and if user tries to use it
as such QEMU will error out with an unknow option error.
Drop it from docs lest it confuse users.

Fixes: b155eb1d04 ("smbios: document cmdline options for smbios type 2-4, 17 structures")
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <1558448611-315074-1-git-send-email-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 39dc170429..0d8beb4afd 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2080,7 +2080,7 @@ Specify SMBIOS type 0 fields
 @item -smbios type=1[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,uuid=@var{uuid}][,sku=@var{str}][,family=@var{str}]
 Specify SMBIOS type 1 fields
 
-@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}][,family=@var{str}]
+@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}]
 Specify SMBIOS type 2 fields
 
 @item -smbios type=3[,manufacturer=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,sku=@var{str}]
-- 
MST



         reply	other threads:[~2019-05-21 14:35 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 16:37 [Qemu-devel] [PULL 00/10] virtio, pci, pc: cleanups Michael S. Tsirkin
2019-04-30  6:10 ` [Qemu-devel] [PATCH] vhost: remove the dead code Jie Wang
2019-04-30  6:10   ` Jie Wang
2019-05-01 16:38   ` Stefan Hajnoczi
2019-05-01 16:38     ` Stefan Hajnoczi
2019-05-29 12:12     ` [Qemu-devel] Ping " Jie Wang
2019-05-29 16:37   ` [Qemu-devel] [PULL 08/10] " Michael S. Tsirkin
2019-06-03 18:08   ` [Qemu-devel] [PULL v2 07/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 07/17] " Michael S. Tsirkin
2019-04-30  6:29 ` [Qemu-devel] [PATCH] vhost: fix incorrect print type Jie Wang
2019-04-30  6:29   ` Jie Wang
2019-04-30  8:48   ` Philippe Mathieu-Daudé
2019-04-30  8:48     ` Philippe Mathieu-Daudé
2019-05-29 13:13     ` Philippe Mathieu-Daudé
2019-06-06  9:20       ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-05-02  8:30   ` [Qemu-devel] " no-reply
2019-05-02  8:30     ` no-reply
2019-05-02  9:34   ` no-reply
2019-05-02  9:34     ` no-reply
2019-05-29 16:37   ` [Qemu-devel] [PULL 09/10] " Michael S. Tsirkin
2019-06-03 18:08   ` [Qemu-devel] [PULL v2 08/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 08/17] " Michael S. Tsirkin
2019-04-30  7:15 ` [Qemu-devel] [PATCH] vhost: fix memory leak in vhost_user_scsi_realize Jie Wang
2019-04-30  7:15   ` Jie Wang
2019-05-01 16:40   ` Stefan Hajnoczi
2019-05-01 16:40     ` Stefan Hajnoczi
2019-05-29 12:12     ` [Qemu-devel] Ping " Jie Wang
2019-05-29 16:37   ` [Qemu-devel] [PULL 10/10] " Michael S. Tsirkin
2019-06-03 18:08   ` [Qemu-devel] [PULL v2 09/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 09/17] " Michael S. Tsirkin
2019-05-21 14:23 ` Igor Mammedov [this message]
2019-05-29 16:37   ` [Qemu-devel] [PULL 07/10] docs: smbios: remove family=x from type2 entry description Michael S. Tsirkin
2019-06-03 18:08   ` [Qemu-devel] [PULL v2 06/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 06/17] " Michael S. Tsirkin
2019-05-29 16:37 ` [Qemu-devel] [PULL 01/10] bios-tables-test: add diff allowed list Michael S. Tsirkin
2019-05-29 22:02 ` [Qemu-devel] [PULL 00/10] virtio, pci, pc: cleanups Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2019-06-05 20:00 [Qemu-devel] [PULL v3 00/17] virtio, pci, pc: cleanups, features Michael S. Tsirkin
2019-06-05 20:00 ` [Qemu-devel] [PULL v3 10/17] bios-tables-test: add diff allowed list Michael S. Tsirkin
2019-06-05 20:00 ` [Qemu-devel] [PULL v3 14/17] bios-tables-test: list all tables that differ Michael S. Tsirkin
2019-06-05 20:00 ` [Qemu-devel] [PULL v3 17/17] bios-tables-test: ignore identical binaries Michael S. Tsirkin
2019-06-06 13:08 ` [Qemu-devel] [PULL v3 00/17] virtio, pci, pc: cleanups, features Peter Maydell
2019-06-03 18:08 [Qemu-devel] [PULL v2 00/14] " Michael S. Tsirkin
2019-06-03 18:08 ` [Qemu-devel] [PULL v2 10/14] bios-tables-test: add diff allowed list Michael S. Tsirkin
2019-06-03 18:09 ` [Qemu-devel] [PULL v2 14/14] bios-tables-test: list all tables that differ Michael S. Tsirkin
2019-06-04 15:57 ` [Qemu-devel] [PULL v2 00/14] virtio, pci, pc: cleanups, features Peter Maydell
2019-06-04 16:48   ` Michael S. Tsirkin
2019-06-04 16:55     ` Peter Maydell
2019-06-04 17:09       ` Michael S. Tsirkin
2019-06-03 11:22 [Qemu-devel] [PATCH v6 0/2] tests: acpi: ARM testing support Igor Mammedov
2019-06-03 11:22 ` [Qemu-devel] [PATCH v6 1/2] tests: add expected ACPI tables for arm/virt board Igor Mammedov
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 15/17] " Michael S. Tsirkin
2019-06-03 11:22 ` [Qemu-devel] [PATCH v6 2/2] tests: acpi: add simple arm/virt testcase Igor Mammedov
2019-06-03 16:08   ` Laszlo Ersek
2019-06-04 11:51     ` Igor Mammedov
2019-06-04 17:13       ` Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 16/17] " Michael S. Tsirkin
2019-05-21  6:28 [Qemu-devel] [PATCH v6 0/2] Extract build_mcfg Part 2 Wei Yang
2019-05-21  6:28 ` [Qemu-devel] [PATCH v6 1/2] hw/acpi: Consolidate build_mcfg to pci.c Wei Yang
2019-05-22  9:11   ` Igor Mammedov
2019-05-29 16:37   ` [Qemu-devel] [PULL 02/10] " Michael S. Tsirkin
2019-06-03 18:08   ` [Qemu-devel] [PULL v2 01/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 01/17] " Michael S. Tsirkin
2019-05-21  6:28 ` [Qemu-devel] [PATCH v6 2/2] acpi: pci: use build_append_foo() API to construct MCFG Wei Yang
2019-05-29 16:37   ` [Qemu-devel] [PULL 03/10] " Michael S. Tsirkin
2019-06-03 18:08   ` [Qemu-devel] [PULL v2 02/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 02/17] " Michael S. Tsirkin
2019-05-13  6:19 [Qemu-devel] [PATCH v4 0/5] Simplify some not-really-necessary PCI bus callbacks David Gibson
2019-05-13  6:19 ` [Qemu-devel] [PATCH v4 1/5] pcie: Remove redundant test in pcie_mmcfg_data_{read, write}() David Gibson
2019-05-13  6:19 ` [Qemu-devel] [PATCH v4 2/5] pci: Simplify pci_bus_is_root() David Gibson
2019-05-13  6:19 ` [Qemu-devel] [PATCH v4 3/5] pcie: Simplify pci_adjust_config_limit() David Gibson
2019-05-29 16:37   ` [Qemu-devel] [PULL 04/10] " Michael S. Tsirkin
2019-06-03 18:08   ` [Qemu-devel] [PULL v2 03/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 03/17] " Michael S. Tsirkin
2019-05-13  6:19 ` [Qemu-devel] [PATCH v4 4/5] pci: Make is_bridge a bool David Gibson
2019-05-29 16:37   ` [Qemu-devel] [PULL 05/10] " Michael S. Tsirkin
2019-06-03 18:08   ` [Qemu-devel] [PULL v2 04/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 04/17] " Michael S. Tsirkin
2019-05-13  6:19 ` [Qemu-devel] [PATCH v4 5/5] pci: Fold pci_get_bus_devfn() into its sole caller David Gibson
2019-05-13  8:02   ` Greg Kurz
2019-05-29 16:37   ` [Qemu-devel] [PULL 06/10] " Michael S. Tsirkin
2019-06-03 18:08   ` [Qemu-devel] [PULL v2 05/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 05/17] " Michael S. Tsirkin
2019-04-16 12:59 [Qemu-devel] [PATCH v2 0/3] vhost-scsi: Support migration Liran Alon
2019-04-16 12:59 ` Liran Alon
2019-04-16 12:59 ` [Qemu-devel] [PATCH v2 1/3] vhost-scsi: The vhost backend should be stopped when the VM is not running Liran Alon
2019-04-16 12:59   ` Liran Alon
2019-06-03 18:09   ` [Qemu-devel] [PULL v2 11/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 11/17] " Michael S. Tsirkin
2019-04-16 12:59 ` [Qemu-devel] [PATCH v2 2/3] vhost-scsi: Add VMState descriptor Liran Alon
2019-04-16 12:59   ` Liran Alon
2019-06-03 18:09   ` [Qemu-devel] [PULL v2 12/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 12/17] " Michael S. Tsirkin
2019-04-16 12:59 ` [Qemu-devel] [PATCH v2 3/3] vhost-scsi: Allow user to enable migration Liran Alon
2019-04-16 12:59   ` Liran Alon
2019-06-03 18:09   ` [Qemu-devel] [PULL v2 13/14] " Michael S. Tsirkin
2019-06-05 20:00   ` [Qemu-devel] [PULL v3 13/17] " Michael S. Tsirkin
2019-04-18  9:41 ` [Qemu-devel] [PATCH v2 0/3] vhost-scsi: Support migration Stefan Hajnoczi
2019-04-18  9:41   ` Stefan Hajnoczi
2019-04-24 16:38   ` Liran Alon
2019-04-24 16:38     ` Liran Alon
2019-04-25  8:38     ` Stefan Hajnoczi
2019-04-25  8:38       ` Stefan Hajnoczi
2019-04-25 17:53       ` Michael S. Tsirkin
2019-04-25 17:53         ` Michael S. Tsirkin
2019-05-10 11:48         ` Liran Alon
2019-06-02 23:40         ` Liran Alon
2019-06-03  0:39           ` Michael S. Tsirkin
2019-06-12 15:26           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1558448611-315074-1-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).