From: Jie Wang <wangjie88@huawei.com>
To: <qemu-devel@nongnu.org>, <qemu-block@nongnu.org>
Cc: pbonzini@redhat.com, eric.fangyi@huawei.com, wangjie88@huawei.com
Subject: [Qemu-devel] [PATCH] pr-manager-helper: fix pr process been killed when reconectting
Date: Tue, 28 May 2019 21:06:36 +0800 [thread overview]
Message-ID: <1559048796-57016-1-git-send-email-wangjie88@huawei.com> (raw)
if pr-helper been killed and qemu send disconnect event to libvirt
and libvirt started a new pr-helper process, the new pr-heleper
been killed again when qemu is connectting to the new pr-helper,
qemu will never send disconnect to libvirt, and libvirt will never
receive connected event.
Signed-off-by: Jie Wang <wangjie88@huawei.com>
---
scsi/pr-manager-helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c
index 438380fced..b7341b8f47 100644
--- a/scsi/pr-manager-helper.c
+++ b/scsi/pr-manager-helper.c
@@ -120,6 +120,7 @@ static int pr_manager_helper_initialize(PRManagerHelper *pr_mgr,
if (local_err) {
object_unref(OBJECT(sioc));
error_propagate(errp, local_err);
+ pr_manager_send_status_changed_event(pr_mgr);
return -ENOTCONN;
}
--
2.16.2.windows.1
next reply other threads:[~2019-05-28 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 13:06 Jie Wang [this message]
2019-05-28 17:45 ` [Qemu-devel] [Qemu-block] [PATCH] pr-manager-helper: fix pr process been killed when reconectting Paolo Bonzini
2019-05-29 7:33 ` Michal Privoznik
2019-05-29 8:37 ` Jie Wang
2019-05-29 9:37 ` Paolo Bonzini
2019-05-29 9:34 ` Paolo Bonzini
2019-05-30 10:08 ` Michal Privoznik
2019-05-30 10:59 ` Paolo Bonzini
2019-06-11 13:51 ` wangjie (P)
2019-06-11 14:46 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559048796-57016-1-git-send-email-wangjie88@huawei.com \
--to=wangjie88@huawei.com \
--cc=eric.fangyi@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).