From: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
To: qemu-devel@nongnu.org
Cc: arikalo@wavecomp.com, amarkovic@wavecomp.com
Subject: [Qemu-devel] [PATCH v4 02/10] target/mips: Fix block-comment-related issues im msa_helper.c
Date: Thu, 6 Jun 2019 18:27:12 +0200 [thread overview]
Message-ID: <1559838440-9866-3-git-send-email-aleksandar.markovic@rt-rk.com> (raw)
In-Reply-To: <1559838440-9866-1-git-send-email-aleksandar.markovic@rt-rk.com>
From: Aleksandar Markovic <amarkovic@wavecomp.com>
Fix block-comment-related issues reported by checkpatch for file
msa_helper.c.
Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Reviewed-by: Aleksandar Rikalo <arikalo@wavecomp.com>
Message-Id: <1559745316-1454-3-git-send-email-aleksandar.markovic@rt-rk.com>
---
target/mips/msa_helper.c | 42 +++++++++++++++++++++++++++---------------
1 file changed, 27 insertions(+), 15 deletions(-)
diff --git a/target/mips/msa_helper.c b/target/mips/msa_helper.c
index eacb5a4..851450c 100644
--- a/target/mips/msa_helper.c
+++ b/target/mips/msa_helper.c
@@ -1975,8 +1975,10 @@ static inline int update_msacsr(CPUMIPSState *env, int action, int denormal)
c &= ~FP_UNDERFLOW;
}
- /* Reciprocal operations set only Inexact when valid and not
- divide by zero */
+ /*
+ * Reciprocal operations set only Inexact when valid and not
+ * divide by zero
+ */
if ((action & RECIPROCAL_INEXACT) &&
(c & (FP_INVALID | FP_DIV0)) == 0) {
c = FP_INEXACT;
@@ -1985,15 +1987,19 @@ static inline int update_msacsr(CPUMIPSState *env, int action, int denormal)
cause = c & enable; /* all current enabled exceptions */
if (cause == 0) {
- /* No enabled exception, update the MSACSR Cause
- with all current exceptions */
+ /*
+ * No enabled exception, update the MSACSR Cause
+ * with all current exceptions
+ */
SET_FP_CAUSE(env->active_tc.msacsr,
(GET_FP_CAUSE(env->active_tc.msacsr) | c));
} else {
/* Current exceptions are enabled */
if ((env->active_tc.msacsr & MSACSR_NX_MASK) == 0) {
- /* Exception(s) will trap, update MSACSR Cause
- with all enabled exceptions */
+ /*
+ * Exception(s) will trap, update MSACSR Cause
+ * with all enabled exceptions
+ */
SET_FP_CAUSE(env->active_tc.msacsr,
(GET_FP_CAUSE(env->active_tc.msacsr) | c));
}
@@ -3059,9 +3065,11 @@ void helper_msa_fexdo_df(CPUMIPSState *env, uint32_t df, uint32_t wd,
switch (df) {
case DF_WORD:
for (i = 0; i < DF_ELEMENTS(DF_WORD); i++) {
- /* Half precision floats come in two formats: standard
- IEEE and "ARM" format. The latter gains extra exponent
- range by omitting the NaN/Inf encodings. */
+ /*
+ * Half precision floats come in two formats: standard
+ * IEEE and "ARM" format. The latter gains extra exponent
+ * range by omitting the NaN/Inf encodings.
+ */
flag ieee = 1;
MSA_FLOAT_BINOP(Lh(pwx, i), from_float32, pws->w[i], ieee, 16);
@@ -3617,9 +3625,11 @@ void helper_msa_fexupl_df(CPUMIPSState *env, uint32_t df, uint32_t wd,
switch (df) {
case DF_WORD:
for (i = 0; i < DF_ELEMENTS(DF_WORD); i++) {
- /* Half precision floats come in two formats: standard
- IEEE and "ARM" format. The latter gains extra exponent
- range by omitting the NaN/Inf encodings. */
+ /*
+ * Half precision floats come in two formats: standard
+ * IEEE and "ARM" format. The latter gains extra exponent
+ * range by omitting the NaN/Inf encodings.
+ */
flag ieee = 1;
MSA_FLOAT_BINOP(pwx->w[i], from_float16, Lh(pws, i), ieee, 32);
@@ -3651,9 +3661,11 @@ void helper_msa_fexupr_df(CPUMIPSState *env, uint32_t df, uint32_t wd,
switch (df) {
case DF_WORD:
for (i = 0; i < DF_ELEMENTS(DF_WORD); i++) {
- /* Half precision floats come in two formats: standard
- IEEE and "ARM" format. The latter gains extra exponent
- range by omitting the NaN/Inf encodings. */
+ /*
+ * Half precision floats come in two formats: standard
+ * IEEE and "ARM" format. The latter gains extra exponent
+ * range by omitting the NaN/Inf encodings.
+ */
flag ieee = 1;
MSA_FLOAT_BINOP(pwx->w[i], from_float16, Rh(pws, i), ieee, 32);
--
2.7.4
next prev parent reply other threads:[~2019-06-06 16:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 16:27 [Qemu-devel] [PATCH v4 00/10] Amend and clean up MSA support Aleksandar Markovic
2019-06-06 16:27 ` [Qemu-devel] [PATCH v4 01/10] target/mips: Fix space-related format issues im msa_helper.c Aleksandar Markovic
2019-06-06 16:27 ` Aleksandar Markovic [this message]
2019-06-06 16:27 ` [Qemu-devel] [PATCH v4 03/10] target/mips: Outline places for future MSA helpers Aleksandar Markovic
2019-06-06 16:27 ` [Qemu-devel] [PATCH v4 04/10] target/mips: Unroll loops in helpers for MSA logic instructions Aleksandar Markovic
2019-06-06 16:27 ` [Qemu-devel] [PATCH v4 05/10] tests/tcg: target/mips: Amend and rearrange MSA wrappers Aleksandar Markovic
2019-06-06 16:27 ` [Qemu-devel] [PATCH v4 06/10] tests/tcg: target/mips: Add tests for MSA shift instructions Aleksandar Markovic
2019-06-06 16:27 ` [Qemu-devel] [PATCH v4 07/10] tests/tcg: target/mips: Move four tests to a better location Aleksandar Markovic
2019-06-06 16:27 ` [Qemu-devel] [PATCH v4 08/10] tests/tcg: target/mips: Add utility function reset_msa_registers() Aleksandar Markovic
2019-06-06 16:27 ` [Qemu-devel] [PATCH v4 09/10] tests/tcg: target/mips: Add tests for MSA FP max/min instructions Aleksandar Markovic
2019-06-06 16:27 ` [Qemu-devel] [PATCH v4 10/10] tests/tcg: target/mips: Add README for MSA tests Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559838440-9866-3-git-send-email-aleksandar.markovic@rt-rk.com \
--to=aleksandar.markovic@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).