qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>, qemu-ppc <qemu-ppc@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-ppc]  [Qemu-arm] qom-test
Date: Fri, 27 Apr 2018 18:36:38 +0200	[thread overview]
Message-ID: <155fc4fe-f8d6-a3d9-0f50-d5384a09835a@redhat.com> (raw)
In-Reply-To: <87muxoehnp.fsf@dusky.pond.sub.org>

On 27.04.2018 18:30, Markus Armbruster wrote:
> Thomas Huth <thuth@redhat.com> writes:
> 
>> On 27.04.2018 12:20, Peter Maydell wrote:
>>> On 27 April 2018 at 07:06, Thomas Huth <thuth@redhat.com> wrote:
[...]
>>>> Shall we change qom-test to also only test with the "none" machine in
>>>> the normal "make check" mode and only do the full test with all machines
>>>> in "make check SPEED=slow" ?
>>>
>>> We definitely want something that tries to instantiate every
>>> machine, because that does catch bugs.
>>
>> Yes, after having a closer look at this one, I also think that we should
>> *not* change it to run with "none" by default only. The 'qom-list'
>> command results in quite a different output depending on which machine
>> you run it on.
> 
> Only running "none" is too naive.

For the targets that have "versioned" machine types, I think we could
skip all the older machine versions, so that we only test with
pc-i440fx-2.12 but not with pc-i440fx-2.11 and older anymore. That would
need some more or less clever algorithm to detect the latest version,
though.

 Thomas

  reply	other threads:[~2018-04-27 16:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19  9:39 [Qemu-devel] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none" Thomas Huth
2018-03-19 20:37 ` Eduardo Habkost
2018-04-17 12:12 ` Markus Armbruster
2018-04-17 12:52   ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2018-04-17 13:15     ` Markus Armbruster
2018-04-26 10:24   ` [Qemu-devel] " Thomas Huth
2018-04-26 11:54     ` Markus Armbruster
2018-04-26 15:27       ` Thomas Huth
2018-04-27  0:34       ` Eduardo Habkost
2018-04-27  3:45         ` Thomas Huth
2018-04-27  6:06       ` [Qemu-devel] qom-test (was: [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none") Thomas Huth
2018-04-27  6:29         ` [Qemu-devel] qom-test Markus Armbruster
2018-04-27 10:20         ` [Qemu-devel] [Qemu-arm] qom-test (was: [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none") Peter Maydell
2018-04-27 10:24           ` [Qemu-devel] [Qemu-arm] qom-test Thomas Huth
2018-04-27 16:30             ` Markus Armbruster
2018-04-27 16:36               ` Thomas Huth [this message]
2018-04-26 11:45 ` [Qemu-devel] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none" Markus Armbruster
2018-04-26 15:20   ` Thomas Huth
2018-04-27  0:32     ` Eduardo Habkost
2018-04-27  3:52       ` Thomas Huth
2018-04-27  6:31       ` Markus Armbruster
2018-04-27  7:31         ` Thomas Huth
2018-04-27  8:05           ` Markus Armbruster
2018-05-07 13:53         ` Eduardo Habkost
2018-05-07 16:50           ` Markus Armbruster
2018-05-07 17:02             ` Thomas Huth
2018-05-07 17:04             ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2018-05-07 18:21             ` [Qemu-devel] " Eduardo Habkost
2018-05-07 19:13               ` Thomas Huth
2018-05-07 19:32                 ` Eduardo Habkost
2018-05-08  5:33                   ` [Qemu-devel] Running QEMU without default devices / kernel / bios (was: Test devices with all machines, not only with "none") Thomas Huth
2018-05-08 10:47                     ` [Qemu-devel] Running QEMU without default devices / kernel / bios Thomas Huth
2018-05-08 16:40                     ` [Qemu-devel] Running QEMU without default devices / kernel / bios (was: Test devices with all machines, not only with "none") Eduardo Habkost
2018-05-09  7:41                       ` [Qemu-devel] [Qemu-ppc] Running QEMU without default devices / kernel / bios Thomas Huth
2018-05-09 11:36                         ` Markus Armbruster
2018-05-08  5:41                   ` [Qemu-devel] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none" Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155fc4fe-f8d6-a3d9-0f50-d5384a09835a@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).