From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E83E2C43613 for ; Mon, 24 Jun 2019 06:51:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3A7220674 for ; Mon, 24 Jun 2019 06:51:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="sCrCgWma" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3A7220674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48300 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfIpJ-00060Q-1l for qemu-devel@archiver.kernel.org; Mon, 24 Jun 2019 02:51:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46120) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfInU-0004ao-CL for qemu-devel@nongnu.org; Mon, 24 Jun 2019 02:49:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfInR-0002yo-Lp for qemu-devel@nongnu.org; Mon, 24 Jun 2019 02:49:46 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:35227) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfInR-0002ua-Fl for qemu-devel@nongnu.org; Mon, 24 Jun 2019 02:49:45 -0400 Received: by mail-pg1-x52b.google.com with SMTP id s27so6585065pgl.2 for ; Sun, 23 Jun 2019 23:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=1OMlUS5nPfK95593P0uZOUMCquD6tXw4v+9sW3dINBc=; b=sCrCgWma4bLL7s2AZuy/yricA/5LljGCGp7HPfASPycN17OkucYbaHRFnHxAZJXHZt 96aNzICY+fuWWD5nOU0TfaTUX6S6+EYCcb+fZRaq0+ki5/zs/uZsFkXUvbUKYpn56HEK 527mzfzyEVBGimXiqao8H+oZ23bmp8TzLJtZu0We7UV4e41b57wggrJoGSmnE+jXqu6p uGtngIGauwX2OC/XqXeYugJegDqcgrUl7v5zh5shbHD9y9S7+YtrPafxATvv/sr8QzkI o8LvjExcZ/3sOkDVtbyg89nolKMIlq/Uav9IPHUTdKnKK1Ve3mO3plV4lCO7IwFOQ6vT AESA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1OMlUS5nPfK95593P0uZOUMCquD6tXw4v+9sW3dINBc=; b=FY5foV4J5MfZlksoX0/Q8HN1jn/Cu/cpEK2RacfkQ9QEfDFR9lZA2XQTUhiNAkH+R6 +YrPr5AwYRkIhMMrFLl7Iefl+0RsKLqr5nkjrZJIg3t+PT1JvSqqfaihQTV3IAHW1z2q Xo9ChC9DJxjMSYeqW6OpXLUjvlkBP+5gkIU6srUgUzM91FAHQHGYN1nezDMQ4jvbCw80 Da+DrHx+fAGpQejhEN2wTo5RAjLKNb4TgfjtN2Eph4JTShCCIyr4vSx1curJLFqUeul+ 5yiFCjmjlc2I9AGuexaM2M2qHEaWMpzWQMoXFtKuYRG08wk35v1EwO2uphGbkDoE+9TX tYrw== X-Gm-Message-State: APjAAAXhAVZN+HvPPqSZCpgVv9Ljm9kGKHpgdOG+uB2KylvKZQzLLe1e ONeFYGehXoXULqBKAS0850M8/A== X-Google-Smtp-Source: APXvYqzrbdvIAp4Vj/tDXEy8Q/Q03r9k7OHWcAnrS+V7TjOff3NNtIl+zrcMHudRYxClgD2iGZvSFA== X-Received: by 2002:a17:90a:2486:: with SMTP id i6mr22762220pje.125.1561358983138; Sun, 23 Jun 2019 23:49:43 -0700 (PDT) Received: from always-ThinkPad-T480.bytedance.net ([61.120.150.76]) by smtp.gmail.com with ESMTPSA id n17sm17734259pfq.182.2019.06.23.23.49.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 23 Jun 2019 23:49:42 -0700 (PDT) From: zhenwei pi To: kwolf@redhat.com, mreitz@redhat.com, eblake@redhat.com Date: Mon, 24 Jun 2019 14:49:33 +0800 Message-Id: <1561358976-5183-1-git-send-email-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52b Subject: [Qemu-devel] [PATCH V2 0/3] Add block size histogram qapi interface X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, qemu-block@nongnu.org, vsementsov@virtuozzo.com, qemu-devel@nongnu.org, pizhenwei@bytedance.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Modify command 'block-latency-histogram-set' to make block histogram interface common to use. And support block size histogram. Thanks to Eric Blake&Vladimir Sementsov-Ogievskiy for the suggestions. This command has been tested for half year on QEMU-2.12, and we found that 3K+ virtual machines write 25GB/s totally, the block size histogram like following: 0 ~ 8k: 58% ~ 62% 8k ~ 32k: 10% ~ 12% 32k ~ 128k: 2% ~ 3% 128K ~ 512K: 24% ~ 26% 512K ~ : ... And the histogram data help us to optimise backend distributed storage. zhenwei pi (3): block/accounting: rename struct BlockLatencyHistogram block/accounting: introduce block size histogram qapi: make block histogram interface common block/accounting.c | 62 ++++++++++++++++++++-------- block/qapi.c | 32 ++++++++------ blockdev.c | 33 +++++++++++---- include/block/accounting.h | 13 +++--- qapi/block-core.json | 101 +++++++++++++++++++++++++++------------------ 5 files changed, 158 insertions(+), 83 deletions(-) -- 2.11.0