Re: [Qemu-devel] [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20190624173935.25747-1-mreitz@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190624173935.25747-1-mreitz@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
ddd669a block: Make use of QAPI defaults
3bcf922 iotests: qcow2's encrypt.format is now optional
155c1db iotests: Test internal option typing
364eac1 block: Try to create well typed json:{} filenames
11726d2 qapi: Formalize qcow encryption probing
567644f qapi: Formalize qcow2 encryption probing
4eb3ca4 tests: Add QAPI optional discriminator tests
f3d9f53 tests: Test QAPI default values for struct members
2862824 test-qapi: Print struct members' default values
ff7a7c5 qapi: Document default values for struct members
faef37f qapi: Allow optional discriminators
64ae73c qapi: Introduce default values for struct members
f485950 qapi: Move to_c_string() to common.py
8711bb4 qapi: Parse numeric values

=== OUTPUT BEGIN ===
1/14 Checking commit 8711bb4c30f3 (qapi: Parse numeric values)
2/14 Checking commit f485950c4595 (qapi: Move to_c_string() to common.py)
3/14 Checking commit 64ae73cfedd6 (qapi: Introduce default values for struct members)
4/14 Checking commit faef37f6cd45 (qapi: Allow optional discriminators)
5/14 Checking commit ff7a7c5b6024 (qapi: Document default values for struct members)
6/14 Checking commit 28628249dcf1 (test-qapi: Print struct members' default values)
7/14 Checking commit f3d9f5343a99 (tests: Test QAPI default values for struct members)
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#106: FILE: tests/qapi-schema/qapi-schema-test.out:420:
+    member str: str optional=True default=foo \鹿""'
                                                    ^

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#111: 
new file mode 100644

total: 1 errors, 1 warnings, 162 lines checked

Patch 7/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/14 Checking commit 4eb3ca457ca3 (tests: Add QAPI optional discriminator tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

total: 0 errors, 1 warnings, 67 lines checked

Patch 8/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/14 Checking commit 567644f6aaa8 (qapi: Formalize qcow2 encryption probing)
10/14 Checking commit 11726d25c367 (qapi: Formalize qcow encryption probing)
11/14 Checking commit 364eac1f31fc (block: Try to create well typed json:{} filenames)
12/14 Checking commit 155c1dbdf3f0 (iotests: Test internal option typing)
13/14 Checking commit 3bcf92270e86 (iotests: qcow2's encrypt.format is now optional)
14/14 Checking commit ddd669ad96a0 (block: Make use of QAPI defaults)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190624173935.25747-1-mreitz@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com