From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D58C46499 for ; Fri, 5 Jul 2019 20:31:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BA7A21670 for ; Fri, 5 Jul 2019 20:31:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W1C4IIIn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BA7A21670 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjUrq-0004Wx-Gs for qemu-devel@archiver.kernel.org; Fri, 05 Jul 2019 16:31:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34183) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjUk9-0004Ld-W3 for qemu-devel@nongnu.org; Fri, 05 Jul 2019 16:23:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjUk4-0002ny-H6 for qemu-devel@nongnu.org; Fri, 05 Jul 2019 16:23:39 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:46956) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjUk0-0002gH-JE for qemu-devel@nongnu.org; Fri, 05 Jul 2019 16:23:33 -0400 Received: by mail-wr1-x42b.google.com with SMTP id z1so6392869wru.13 for ; Fri, 05 Jul 2019 13:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=2QJXgDdeciu+QM4e3C1K2WEVvDtyNAWGx3hRO2WruJ0=; b=W1C4IIInxHmm2j6ms/74hDmp0LtqX9wHVoNRfffyya+p8megN0YXbeVuSuCnnEyNTT GVY8mjl4MdoUqydVMgWIRfnqBQcruMIb4BhZxkBsGpb4Vn5c5P+8/Uzqb3i0JaZ8aAxd 2t/XnVwQ8mUgWxTXlXWsg+Xgjab0w5reGBA7mN/UYmZFd9m/r8YlMKU0ljiqxcWxeUtf mgd+pikrgOjiNwXDAemnUOBY748n3QmLsgNbJ4ceexdZxJcHwFVvg4hhBoYS6Afdh/ua Udj7BQ3I67GVJoFTIcVKUfJ0drngeo3NSXJdmZ8MlytyMCWiMwhjRUIxdQ9wSVCMGr5e S/Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=2QJXgDdeciu+QM4e3C1K2WEVvDtyNAWGx3hRO2WruJ0=; b=bRt/h0T4oQjFalToH4aGsu4j9E9QOIAsJLeYKIz+e7CJI8bE5TfF+4U12ctGlyOVNF RkRaMhk4MVnBIte6O3bed1PSh5U5MlfEgST/qsqY1Gc5SfpDleUHb5SXvL+UBc8TuaSf JarYzT3ZpFgBWkczZKCd5vRZ/6121ar1WMPmpnVbKrANBweYinDDeevqqTkLwzgT1ctW thiqeRYoTgKrm1PYOfr0IIHkdJmPwDHlvsyObLERxd3caU7NQ7k5cvk0a9YTCd+Kb9D+ kfqN400iZuqZJc3j+s9UOgDf7X4RbCSu2NC5FeMCrgCpstyGcbt5IBjuXIUfJuPzQqeQ xx4w== X-Gm-Message-State: APjAAAV2swoAuRqsXXGfjpD8KMBl09onLi6wkI8RPW7ftyUVT/aydn9A Vf7svX6ZGOm+1Rdj15zEOou7ZcG47r8= X-Google-Smtp-Source: APXvYqxytVifRVE+fgeroUdTtAW4PhIvmRt485rGBW7kvxqAMnBWjWNVGxoYN8peMrf+lWsl2oaNCg== X-Received: by 2002:adf:c706:: with SMTP id k6mr5239400wrg.40.1562358205626; Fri, 05 Jul 2019 13:23:25 -0700 (PDT) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id v23sm3035875wmj.32.2019.07.05.13.23.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jul 2019 13:23:25 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 5 Jul 2019 22:23:12 +0200 Message-Id: <1562358202-28008-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1562358202-28008-1-git-send-email-pbonzini@redhat.com> References: <1562358202-28008-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42b Subject: [Qemu-devel] [PULL 02/12] checkpatch: do not warn for multiline parenthesized returned value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" While indeed we do not want to have return (a); it is less clear that this applies to return (a && b); Some editors indent more nicely if you have parentheses, and some people's eyes may appreciate that as well. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Reviewed-by: Richard Henderson Message-Id: <1561116534-21814-1-git-send-email-pbonzini@redhat.com> Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c2aaf42..2f81371 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2296,7 +2296,8 @@ sub process { $value =~ s/\([^\(\)]*\)/1/) { } #print "value<$value>\n"; - if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) { + if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/ && + $line =~ /;$/) { ERROR("return is not a function, parentheses are not required\n" . $herecurr); } elsif ($spacing !~ /\s+/) { -- 1.8.3.1