From: zhenwei pi <pizhenwei@bytedance.com>
To: kwolf@redhat.com, vsementsov@virtuozzo.com, eblake@redhat.com
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
pizhenwei@bytedance.com, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/3] Add block size histogram qapi interface
Date: Mon, 8 Jul 2019 17:32:26 +0800 [thread overview]
Message-ID: <1562578349-12333-1-git-send-email-pizhenwei@bytedance.com> (raw)
Modify command 'block-latency-histogram-set' to make block histogram
interface common to use. And support block size histogram.
Thanks to Eric Blake&Vladimir Sementsov-Ogievskiy for the suggestions.
This command has been tested for half year on QEMU-2.12, and we found
that 3K+ virtual machines write 25GB/s totally, the block size
histogram like following:
0 ~ 8k: 58% ~ 62%
8k ~ 32k: 10% ~ 12%
32k ~ 128k: 2% ~ 3%
128K ~ 512K: 24% ~ 26%
512K ~ : ...
And the histogram data help us to optimise backend distributed
storage.
Changelog:
v2:
- make 'block-latency-histogram-set' common.
- remove duplicated functions.
- fix uncommon indentation(reviewed by Vladimir Sementsov-Ogievskiy).
zhenwei pi (3):
block/accounting: rename struct BlockLatencyHistogram
block/accounting: introduce block size histogram
qapi: make block histogram interface common
block/accounting.c | 62 ++++++++++++++++++++--------
block/qapi.c | 32 ++++++++------
blockdev.c | 33 +++++++++++----
include/block/accounting.h | 13 +++---
qapi/block-core.json | 101 +++++++++++++++++++++++++++------------------
5 files changed, 158 insertions(+), 83 deletions(-)
--
2.11.0
next reply other threads:[~2019-07-08 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 9:32 zhenwei pi [this message]
2019-07-08 9:32 ` [Qemu-devel] [PATCH v2 1/3] block/accounting: rename struct BlockLatencyHistogram zhenwei pi
2019-07-08 9:32 ` [Qemu-devel] [PATCH v2 2/3] block/accounting: introduce block size histogram zhenwei pi
2019-07-08 9:32 ` [Qemu-devel] [PATCH v2 3/3] qapi: make block histogram interface common zhenwei pi
2019-07-25 11:53 ` Vladimir Sementsov-Ogievskiy
-- strict thread matches above, loose matches on Subject: below --
2019-06-24 6:49 [Qemu-devel] [PATCH V2 0/3] Add block size histogram qapi interface zhenwei pi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562578349-12333-1-git-send-email-pizhenwei@bytedance.com \
--to=pizhenwei@bytedance.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).