qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, mreitz@redhat.com,
	andrey.shinkevich@virtuozzo.com, den@openvz.org
Subject: [Qemu-devel] [PATCH v4 4/7] iotests: Valgrind fails with nonexistent directory
Date: Fri, 19 Jul 2019 12:40:01 +0300	[thread overview]
Message-ID: <1563529204-3368-5-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)
In-Reply-To: <1563529204-3368-1-git-send-email-andrey.shinkevich@virtuozzo.com>

The Valgrind uses the exported variable TMPDIR and fails if the
directory does not exist. Let us exclude such a test case from
being run under the Valgrind and notify the user of it.

Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
---
 tests/qemu-iotests/051 | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index ce942a5..f8141ca 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -377,6 +377,10 @@ printf %b "qemu-io $device_id \"write -P 0x33 0 4k\"\ncommit $device_id\n" |
 $QEMU_IO -c "read -P 0x33 0 4k" "$TEST_IMG" | _filter_qemu_io
 
 # Using snapshot=on with a non-existent TMPDIR
+if [ "${VALGRIND_QEMU}" == "y" ]; then
+    _casenotrun "Valgrind needs a valid TMPDIR for itself"
+fi
+VALGRIND_QEMU="" \
 TMPDIR=/nonexistent run_qemu -drive driver=null-co,snapshot=on
 
 # Using snapshot=on together with read-only=on
-- 
1.8.3.1



  parent reply	other threads:[~2019-07-19  9:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19  9:39 [Qemu-devel] [PATCH v4 0/7] Allow Valgrind checking all QEMU processes Andrey Shinkevich
2019-07-19  9:39 ` [Qemu-devel] [PATCH v4 1/7] iotests: allow " Andrey Shinkevich
2019-07-19  9:39 ` [Qemu-devel] [PATCH v4 2/7] iotests: exclude killed processes from running under Valgrind Andrey Shinkevich
2019-07-19  9:40 ` [Qemu-devel] [PATCH v4 3/7] iotests: Add casenotrun report to bash tests Andrey Shinkevich
2019-07-19  9:40 ` Andrey Shinkevich [this message]
2019-07-19  9:40 ` [Qemu-devel] [PATCH v4 5/7] iotests: extended timeout under Valgrind Andrey Shinkevich
2019-07-19  9:40 ` [Qemu-devel] [PATCH v4 6/7] iotests: extend sleeping time " Andrey Shinkevich
2019-07-19  9:40 ` [Qemu-devel] [PATCH v4 7/7] block/nbd: NBDReply is used being uninitialized Andrey Shinkevich
2019-07-19 14:34   ` Eric Blake
2019-07-19 14:43     ` Andrey Shinkevich
2019-07-19 14:44     ` Eric Blake
2019-07-19 15:00       ` Andrey Shinkevich
2019-07-19 15:15         ` Eric Blake
2019-07-19 15:43           ` Andrey Shinkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1563529204-3368-5-git-send-email-andrey.shinkevich@virtuozzo.com \
    --to=andrey.shinkevich@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).