* [Qemu-devel] [PATCH] Fixes: a6862418fec4072 iotests change in 051.out
@ 2019-07-24 8:25 Andrey Shinkevich
2019-07-24 8:47 ` Christian Borntraeger
0 siblings, 1 reply; 3+ messages in thread
From: Andrey Shinkevich @ 2019-07-24 8:25 UTC (permalink / raw)
To: qemu-devel, qemu-block
Cc: kwolf, peter.maydell, mreitz, borntraeger, qemu-s390x,
andrey.shinkevich
The patch "iotests: Set read-zeroes on in null block driver for Valgrind"
needs the change in 051.out when compared against on the s390 system.
Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
---
tests/qemu-iotests/051.out | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out
index 8993835..554c5ca 100644
--- a/tests/qemu-iotests/051.out
+++ b/tests/qemu-iotests/051.out
@@ -149,23 +149,23 @@ QEMU X.Y.Z monitor - type 'help' for more information
=== Cache modes ===
-Testing: -drive driver=null-co,cache=none
+Testing: -drive driver=null-co,read-zeroes=on,cache=none
QEMU X.Y.Z monitor - type 'help' for more information
(qemu) quit
-Testing: -drive driver=null-co,cache=directsync
+Testing: -drive driver=null-co,read-zeroes=on,cache=directsync
QEMU X.Y.Z monitor - type 'help' for more information
(qemu) quit
-Testing: -drive driver=null-co,cache=writeback
+Testing: -drive driver=null-co,read-zeroes=on,cache=writeback
QEMU X.Y.Z monitor - type 'help' for more information
(qemu) quit
-Testing: -drive driver=null-co,cache=writethrough
+Testing: -drive driver=null-co,read-zeroes=on,cache=writethrough
QEMU X.Y.Z monitor - type 'help' for more information
(qemu) quit
-Testing: -drive driver=null-co,cache=unsafe
+Testing: -drive driver=null-co,read-zeroes=on,cache=unsafe
QEMU X.Y.Z monitor - type 'help' for more information
(qemu) quit
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Fixes: a6862418fec4072 iotests change in 051.out
2019-07-24 8:25 [Qemu-devel] [PATCH] Fixes: a6862418fec4072 iotests change in 051.out Andrey Shinkevich
@ 2019-07-24 8:47 ` Christian Borntraeger
2019-07-25 0:23 ` [Qemu-devel] [Qemu-block] " John Snow
0 siblings, 1 reply; 3+ messages in thread
From: Christian Borntraeger @ 2019-07-24 8:47 UTC (permalink / raw)
To: Andrey Shinkevich, qemu-devel, qemu-block
Cc: kwolf, peter.maydell, qemu-s390x, mreitz
On 24.07.19 10:25, Andrey Shinkevich wrote:
> The patch "iotests: Set read-zeroes on in null block driver for Valgrind"
> needs the change in 051.out when compared against on the s390 system.
>
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
FWIW, the Fixes tag should be inside the patch description.
Maybe Kevin will fix this up when applying?
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> ---
> tests/qemu-iotests/051.out | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out
> index 8993835..554c5ca 100644
> --- a/tests/qemu-iotests/051.out
> +++ b/tests/qemu-iotests/051.out
> @@ -149,23 +149,23 @@ QEMU X.Y.Z monitor - type 'help' for more information
>
> === Cache modes ===
>
> -Testing: -drive driver=null-co,cache=none
> +Testing: -drive driver=null-co,read-zeroes=on,cache=none
> QEMU X.Y.Z monitor - type 'help' for more information
> (qemu) quit
>
> -Testing: -drive driver=null-co,cache=directsync
> +Testing: -drive driver=null-co,read-zeroes=on,cache=directsync
> QEMU X.Y.Z monitor - type 'help' for more information
> (qemu) quit
>
> -Testing: -drive driver=null-co,cache=writeback
> +Testing: -drive driver=null-co,read-zeroes=on,cache=writeback
> QEMU X.Y.Z monitor - type 'help' for more information
> (qemu) quit
>
> -Testing: -drive driver=null-co,cache=writethrough
> +Testing: -drive driver=null-co,read-zeroes=on,cache=writethrough
> QEMU X.Y.Z monitor - type 'help' for more information
> (qemu) quit
>
> -Testing: -drive driver=null-co,cache=unsafe
> +Testing: -drive driver=null-co,read-zeroes=on,cache=unsafe
> QEMU X.Y.Z monitor - type 'help' for more information
> (qemu) quit
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] Fixes: a6862418fec4072 iotests change in 051.out
2019-07-24 8:47 ` Christian Borntraeger
@ 2019-07-25 0:23 ` John Snow
0 siblings, 0 replies; 3+ messages in thread
From: John Snow @ 2019-07-25 0:23 UTC (permalink / raw)
To: Christian Borntraeger, Andrey Shinkevich, qemu-devel, qemu-block
Cc: kwolf, peter.maydell, qemu-s390x, mreitz
On 7/24/19 4:47 AM, Christian Borntraeger wrote:
>
>
> On 24.07.19 10:25, Andrey Shinkevich wrote:
>> The patch "iotests: Set read-zeroes on in null block driver for Valgrind"
>> needs the change in 051.out when compared against on the s390 system.
>>
>> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> FWIW, the Fixes tag should be inside the patch description.
> Maybe Kevin will fix this up when applying?
>
If you move the Fixes: into the commit message:
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-25 0:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-24 8:25 [Qemu-devel] [PATCH] Fixes: a6862418fec4072 iotests change in 051.out Andrey Shinkevich
2019-07-24 8:47 ` Christian Borntraeger
2019-07-25 0:23 ` [Qemu-devel] [Qemu-block] " John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).