From: Pankaj Gupta <pagupta@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: amit shah <amit.shah@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-rng: Bump up quota value only when guest requests entropy
Date: Mon, 13 Jul 2015 04:06:22 -0400 (EDT) [thread overview]
Message-ID: <1564041656.31597912.1436774782857.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20150713105605-mutt-send-email-mst@redhat.com>
> On Fri, Jul 10, 2015 at 03:04:00PM +0530, Pankaj Gupta wrote:
> > @@ -196,13 +201,9 @@ static void virtio_rng_device_realize(DeviceState
> > *dev, Error **errp)
> >
> > vrng->vq = virtio_add_queue(vdev, 8, handle_input);
> > vrng->quota_remaining = vrng->conf.max_bytes;
> > -
> > vrng->rate_limit_timer = timer_new_ms(QEMU_CLOCK_VIRTUAL,
> > check_rate_limit, vrng);
>
> BTW I'm not sure QEMU_CLOCK_VIRTUAL is right here.
> We are trying to limit the rate at host.
> Does it matter that guest is not running?
I think, now we will be serving entropy requests only when Guest send those.
In any case Guest should be up and running.
>
> --
> MST
>
>
prev parent reply other threads:[~2015-07-13 8:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 9:34 [Qemu-devel] [PATCH] virtio-rng: Bump up quota value only when guest requests entropy Pankaj Gupta
2015-07-13 6:09 ` Amit Shah
2015-07-13 6:53 ` Pankaj Gupta
2015-07-13 7:34 ` Amit Shah
2015-07-13 7:55 ` Michael S. Tsirkin
2015-07-13 8:52 ` Amit Shah
2015-07-13 8:01 ` Pankaj Gupta
2015-07-13 8:47 ` Amit Shah
2015-07-13 8:58 ` Pankaj Gupta
2015-07-13 7:57 ` Michael S. Tsirkin
2015-07-13 8:06 ` Pankaj Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564041656.31597912.1436774782857.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).