From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38356C31E40 for ; Mon, 12 Aug 2019 15:59:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F0D42085A for ; Mon, 12 Aug 2019 15:59:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F0D42085A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxCjB-0006uY-C2 for qemu-devel@archiver.kernel.org; Mon, 12 Aug 2019 11:59:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49433) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hxCib-0005j6-Sd for qemu-devel@nongnu.org; Mon, 12 Aug 2019 11:58:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxCia-0007tq-R8 for qemu-devel@nongnu.org; Mon, 12 Aug 2019 11:58:45 -0400 Received: from relay.sw.ru ([185.231.240.75]:46396) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxCia-0007si-KG for qemu-devel@nongnu.org; Mon, 12 Aug 2019 11:58:44 -0400 Received: from [172.16.25.136] (helo=localhost.sw.ru) by relay.sw.ru with esmtp (Exim 4.92) (envelope-from ) id 1hxCiV-0001HP-Ra; Mon, 12 Aug 2019 18:58:39 +0300 From: Andrey Shinkevich To: qemu-devel@nongnu.org Date: Mon, 12 Aug 2019 18:58:27 +0300 Message-Id: <1565625509-404969-1-git-send-email-andrey.shinkevich@virtuozzo.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH v4 0/2] char-socket: Fix race condition X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vsementsov@virtuozzo.com, berrange@redhat.com, berto@igalia.com, marcandre.lureau@redhat.com, andrey.shinkevich@virtuozzo.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This fixes a race condition in which the tcp_chr_read() ioc handler can close a connection that is being written to from another thread. v4: The functions qemu_idle_add() and tcp_chr_be_event_closed() were removed because the callback is invoked after the call to object_property_del_all() so, the "chardev" object had been deleted and the segmentation fault occurs. Let's please apply the Alberto's simplified series to avoid the race condition. v3: See the email thread with the Message ID Alberto Garcia (2): main-loop: Fix GSource leak in qio_task_thread_worker() char-socket: Lock tcp_chr_disconnect() chardev/char-socket.c | 16 +++++++++++++--- io/task.c | 1 + 2 files changed, 14 insertions(+), 3 deletions(-) -- 1.8.3.1