qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, amarkovic@wavecomp.com
Subject: [Qemu-devel] [PULL 10/11] target/mips: tests/tcg: Add optional printing of more detailed failure info
Date: Tue, 20 Aug 2019 08:38:02 +0200	[thread overview]
Message-ID: <1566283083-21838-11-git-send-email-aleksandar.markovic@rt-rk.com> (raw)
In-Reply-To: <1566283083-21838-1-git-send-email-aleksandar.markovic@rt-rk.com>

From: Aleksandar Markovic <amarkovic@wavecomp.com>

There is a need for printing input and output data for failure cases,
for debugging purpose. This is achieved by this patch, and only if a
preprocessor constant is manually set to 1. (Assumption is that the
need for such printout is relatively rare.)

Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Reviewed-by: Aleksandar Rikalo <arikalo@wavecomp.com>
Message-Id: <1566216496-17375-37-git-send-email-aleksandar.markovic@rt-rk.com>
---
 tests/tcg/mips/include/test_utils_128.h | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/tests/tcg/mips/include/test_utils_128.h b/tests/tcg/mips/include/test_utils_128.h
index 2fea610..0dd3868 100644
--- a/tests/tcg/mips/include/test_utils_128.h
+++ b/tests/tcg/mips/include/test_utils_128.h
@@ -27,7 +27,8 @@
 #include <inttypes.h>
 #include <string.h>
 
-#define PRINT_RESULTS 0
+#define PRINT_RESULTS    0
+#define PRINT_FAILURES   0
 
 
 static inline int32_t check_results_128(const char *isa_ase_name,
@@ -65,6 +66,26 @@ static inline int32_t check_results_128(const char *isa_ase_name,
             (b128_result[2 * i + 1] == b128_expect[2 * i + 1])) {
             pass_count++;
         } else {
+#if PRINT_FAILURES
+            uint32_t ii;
+            uint64_t a, b;
+
+            printf("\n");
+
+            printf("FAILURE for test case %d!\n", i);
+
+            memcpy(&a, (b128_expect + 2 * i), 8);
+            memcpy(&b, (b128_expect + 2 * i + 1), 8);
+            printf("Expected result : { 0x%016llxULL, 0x%016llxULL, },\n",
+                   a, b);
+
+            memcpy(&a, (b128_result + 2 * i), 8);
+            memcpy(&b, (b128_result + 2 * i + 1), 8);
+            printf("Actual result   : { 0x%016llxULL, 0x%016llxULL, },\n",
+                   a, b);
+
+            printf("\n");
+#endif
             fail_count++;
         }
     }
-- 
2.7.4



  parent reply	other threads:[~2019-08-20  6:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20  6:37 [Qemu-devel] [PULL 00/11] MIPS queue for August 20th, 2019 Aleksandar Markovic
2019-08-20  6:37 ` [Qemu-devel] [PULL 01/11] target/mips: Style improvements in cp0_timer.c Aleksandar Markovic
2019-08-20  6:37 ` [Qemu-devel] [PULL 02/11] target/mips: Style improvements in cpu.c Aleksandar Markovic
2019-08-20  6:37 ` [Qemu-devel] [PULL 03/11] target/mips: Style improvements in machine.c Aleksandar Markovic
2019-08-20  6:37 ` [Qemu-devel] [PULL 04/11] target/mips: Style improvements in translate.c Aleksandar Markovic
2019-08-20  6:37 ` [Qemu-devel] [PULL 05/11] target/mips: Style improvements in cps.c Aleksandar Markovic
2019-08-20  6:37 ` [Qemu-devel] [PULL 06/11] target/mips: Style improvements in mips_fulong2e.c Aleksandar Markovic
2019-08-20  6:37 ` [Qemu-devel] [PULL 07/11] target/mips: Style improvements in mips_int.c Aleksandar Markovic
2019-08-20  6:38 ` [Qemu-devel] [PULL 08/11] target/mips: Style improvements in mips_malta.c Aleksandar Markovic
2019-08-20  6:38 ` [Qemu-devel] [PULL 09/11] target/mips: Style improvements in mips_mipssim.c Aleksandar Markovic
2019-08-20  6:38 ` Aleksandar Markovic [this message]
2019-08-20  6:38 ` [Qemu-devel] [PULL 11/11] target/mips: tests/tcg: Fix target configurations for MSA tests Aleksandar Markovic
2019-08-20 13:14 ` [Qemu-devel] [PULL 00/11] MIPS queue for August 20th, 2019 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1566283083-21838-11-git-send-email-aleksandar.markovic@rt-rk.com \
    --to=aleksandar.markovic@rt-rk.com \
    --cc=amarkovic@wavecomp.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).