From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-rust@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Tanish Desai <tanishdesai37@gmail.com>
Subject: Re: [PATCH 1/2] rust: Kconfig: Factor out whether PL011 is Rust or C
Date: Wed, 19 Mar 2025 22:08:35 +0100 [thread overview]
Message-ID: <15664032-67d9-4a3c-a567-5bf13d30dc96@linaro.org> (raw)
In-Reply-To: <20250319193110.1565578-2-peter.maydell@linaro.org>
On 19/3/25 20:31, Peter Maydell wrote:
> Currently every board that uses the PL011 duplicates the logic that
> selects the Rust implementation if Rust was enabled and the C
> implementation if it does not. Factor this out into a separate
> Kconfig stanza, so that boards can go back to simply doing "select
> PL011" and get whichever implementation is correct for the build.
>
> This fixes a compilation failure if CONFIG_VMAPPLE is enabled
> in a Rust build, because hw/vmapple/Kconfig didn't have the
> "pick the Rust PL011 if Rust is enabled" logic in it.
>
> Fixes: 59f4d65584bd33 ("hw/vmapple/vmapple: Add vmapple machine type")
> Reported-by: Tanish Desai <tanishdesai37@gmail.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/arm/Kconfig | 30 ++++++++++--------------------
> hw/char/Kconfig | 6 ++++++
> hw/char/meson.build | 2 +-
> 3 files changed, 17 insertions(+), 21 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-03-19 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 19:31 [PATCH 0/2] rust: Kconfig: factor out Rust vs C impl choice Peter Maydell
2025-03-19 19:31 ` [PATCH 1/2] rust: Kconfig: Factor out whether PL011 is Rust or C Peter Maydell
2025-03-19 21:08 ` Philippe Mathieu-Daudé [this message]
2025-03-19 19:31 ` [PATCH 2/2] rust: Kconfig: Factor out whether HPET " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15664032-67d9-4a3c-a567-5bf13d30dc96@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=tanishdesai37@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).