From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMyFJ-00051e-3G for qemu-devel@nongnu.org; Tue, 02 Apr 2013 06:15:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMyFD-0004IW-UL for qemu-devel@nongnu.org; Tue, 02 Apr 2013 06:15:16 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:42302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMyFD-0004IC-IX for qemu-devel@nongnu.org; Tue, 02 Apr 2013 06:15:11 -0400 Date: Tue, 2 Apr 2013 06:15:08 -0400 (EDT) From: Paolo Bonzini Message-ID: <1568615688.579198.1364897708613.JavaMail.root@redhat.com> In-Reply-To: <20130402083724.GF2341@dhcp-200-207.str.redhat.com> References: <1364507550-25093-1-git-send-email-aliguori@us.ibm.com> <1364507550-25093-3-git-send-email-aliguori@us.ibm.com> <20130402083724.GF2341@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 2/3] sheepdog: pass NULL for io_flush List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Anthony Liguori , qemu-devel@nongnu.org, Mike Roth > > diff --git a/block/sheepdog.c b/block/sheepdog.c > > index bb67c4c..2bccd9b 100644 > > --- a/block/sheepdog.c > > +++ b/block/sheepdog.c > > @@ -503,13 +503,6 @@ static void restart_co_req(void *opaque) > > qemu_coroutine_enter(co, NULL); > > } > > > > -static int have_co_req(void *opaque) > > -{ > > - /* this handler is set only when there is a pending request, so > > - * always returns 1. */ > > Now you return 1 even when no request is pending (which is the case in > which no io_flush handler would be set before). Why is this correct? > (This is actually a question about PATCH 1/3, I just noticed it here. > Are there more cases like this?) In the dataplane code, the ioeventfd uses an io_flush callback that returns true. Paolo