qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Cc: frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com,
	pasic@linux.ibm.com, borntraeger@de.ibm.com, rth@twiddle.net
Subject: [PATCH v2 3/4] s390x: sclp: fix error handling for oversize control blocks
Date: Fri, 27 Sep 2019 15:33:22 +0200	[thread overview]
Message-ID: <1569591203-15258-4-git-send-email-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <1569591203-15258-1-git-send-email-imbrenda@linux.ibm.com>

From: Janosch Frank <frankja@linux.ibm.com>

Requests over 4k are not a spec exception.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Jason J. Herne <jjherne@linux.ibm.com>
---
 hw/s390x/sclp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
index 73244c9..abb6e50 100644
--- a/hw/s390x/sclp.c
+++ b/hw/s390x/sclp.c
@@ -213,8 +213,7 @@ int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code)
     cpu_physical_memory_read(sccb, &work_sccb, sccb_len);
 
     /* Valid sccb sizes */
-    if (be16_to_cpu(work_sccb.h.length) < sizeof(SCCBHeader) ||
-        be16_to_cpu(work_sccb.h.length) > SCCB_SIZE) {
+    if (be16_to_cpu(work_sccb.h.length) < sizeof(SCCBHeader)) {
         r = -PGM_SPECIFICATION;
         goto out;
     }
-- 
2.7.4



  parent reply	other threads:[~2019-09-27 14:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27 13:33 [PATCH v2 0/4] s390x: SCLP error cleanup Claudio Imbrenda
2019-09-27 13:33 ` [PATCH v2 1/4] s390x: sclp: refactor invalid command check Claudio Imbrenda
2019-09-27 13:42   ` David Hildenbrand
2019-09-27 14:34   ` Christian Borntraeger
2019-09-27 13:33 ` [PATCH v2 2/4] s390x: sclp: boundary check Claudio Imbrenda
2019-09-27 13:42   ` David Hildenbrand
2019-09-27 14:35   ` Christian Borntraeger
2019-09-27 13:33 ` Claudio Imbrenda [this message]
2019-09-27 13:44   ` [PATCH v2 3/4] s390x: sclp: fix error handling for oversize control blocks David Hildenbrand
2019-09-27 14:36   ` Christian Borntraeger
2019-09-27 13:33 ` [PATCH v2 4/4] s390x: Fix SCLP return code when buffer too small Claudio Imbrenda
2019-09-27 13:44   ` David Hildenbrand
2019-09-27 14:46   ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1569591203-15258-4-git-send-email-imbrenda@linux.ibm.com \
    --to=imbrenda@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).