From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: thuth@redhat.com, frankja@linux.ibm.com, david@redhat.com,
cohuck@redhat.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org
Subject: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii
Date: Thu, 28 Nov 2019 13:33:57 +0100 [thread overview]
Message-ID: <1574944437-31182-1-git-send-email-imbrenda@linux.ibm.com> (raw)
The existing s390 bios gets the LOADPARM information from the system using
an SCLP call that specifies a buffer length too small to contain all the
output.
The recent fixes in the SCLP code have exposed this bug, since now the
SCLP call will return an error (as per architecture) instead of
writing partially and completing successfully.
The solution is simply to specify the full page length as the SCCB
length instead of a smaller size.
Fixes: 832be0d8a3bb ("s390x: sclp: Report insufficient SCCB length")
Fixes: 9a22473c70f3 ("pc-bios/s390-ccw: get LOADPARM stored in SCP Read Info")
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
pc-bios/s390-ccw/sclp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/sclp.c b/pc-bios/s390-ccw/sclp.c
index c0223fa..7251f9a 100644
--- a/pc-bios/s390-ccw/sclp.c
+++ b/pc-bios/s390-ccw/sclp.c
@@ -112,7 +112,7 @@ void sclp_get_loadparm_ascii(char *loadparm)
ReadInfo *sccb = (void *)_sccb;
memset((char *)_sccb, 0, sizeof(ReadInfo));
- sccb->h.length = sizeof(ReadInfo);
+ sccb->h.length = SCCB_SIZE;
if (!sclp_service_call(SCLP_CMDW_READ_SCP_INFO, sccb)) {
ebcdic_to_ascii((char *) sccb->loadparm, loadparm, LOADPARM_LEN);
}
--
2.7.4
next reply other threads:[~2019-11-28 12:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 12:33 Claudio Imbrenda [this message]
2019-11-28 12:35 ` [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii Christian Borntraeger
2019-11-28 12:45 ` Cornelia Huck
2019-11-28 12:48 ` Christian Borntraeger
2019-11-28 15:05 ` Peter Maydell
2019-11-29 7:38 ` Christian Borntraeger
2019-11-29 8:10 ` Thomas Huth
2019-11-28 13:11 ` Thomas Huth
2019-11-28 13:16 ` Cornelia Huck
2019-11-28 14:45 ` Christian Borntraeger
2019-11-28 12:37 ` Janosch Frank
2019-11-28 12:44 ` Marc Hartmayer
2019-11-28 12:44 ` Claudio Imbrenda
2019-11-28 13:32 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574944437-31182-1-git-send-email-imbrenda@linux.ibm.com \
--to=imbrenda@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).