* [PATCH] target/mips: Remove unused MEMOP_IDX() macro
@ 2024-10-14 23:22 Philippe Mathieu-Daudé
2024-10-15 0:09 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-10-14 23:22 UTC (permalink / raw)
To: qemu-devel
Cc: Aleksandar Rikalo, Richard Henderson, Jiaxun Yang,
Philippe Mathieu-Daudé, Aurelien Jarno
MEMOP_IDX() is unused since commit 948f88661c6 ("target/mips:
Use cpu_*_data_ra for msa load/store"), remove it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/mips/tcg/msa_helper.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_helper.c
index d2181763e72..1d40383ca4f 100644
--- a/target/mips/tcg/msa_helper.c
+++ b/target/mips/tcg/msa_helper.c
@@ -8211,14 +8211,6 @@ void helper_msa_ffint_u_df(CPUMIPSState *env, uint32_t df, uint32_t wd,
/* Element-by-element access macros */
#define DF_ELEMENTS(df) (MSA_WRLEN / DF_BITS(df))
-#if !defined(CONFIG_USER_ONLY)
-#define MEMOP_IDX(DF) \
- MemOpIdx oi = make_memop_idx(MO_TE | DF | MO_UNALN, \
- mips_env_mmu_index(env));
-#else
-#define MEMOP_IDX(DF)
-#endif
-
#if TARGET_BIG_ENDIAN
static inline uint64_t bswap16x4(uint64_t x)
{
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] target/mips: Remove unused MEMOP_IDX() macro
2024-10-14 23:22 [PATCH] target/mips: Remove unused MEMOP_IDX() macro Philippe Mathieu-Daudé
@ 2024-10-15 0:09 ` Richard Henderson
2024-10-15 14:40 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2024-10-15 0:09 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Aleksandar Rikalo, Jiaxun Yang, Aurelien Jarno
On 10/14/24 16:22, Philippe Mathieu-Daudé wrote:
> MEMOP_IDX() is unused since commit 948f88661c6 ("target/mips:
> Use cpu_*_data_ra for msa load/store"), remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> target/mips/tcg/msa_helper.c | 8 --------
> 1 file changed, 8 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/mips: Remove unused MEMOP_IDX() macro
2024-10-15 0:09 ` Richard Henderson
@ 2024-10-15 14:40 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-10-15 14:40 UTC (permalink / raw)
To: Richard Henderson, qemu-devel
Cc: Aleksandar Rikalo, Jiaxun Yang, Aurelien Jarno
On 14/10/24 21:09, Richard Henderson wrote:
> On 10/14/24 16:22, Philippe Mathieu-Daudé wrote:
>> MEMOP_IDX() is unused since commit 948f88661c6 ("target/mips:
>> Use cpu_*_data_ra for msa load/store"), remove it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
>> ---
>> target/mips/tcg/msa_helper.c | 8 --------
>> 1 file changed, 8 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Thanks, patch queued.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-15 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-14 23:22 [PATCH] target/mips: Remove unused MEMOP_IDX() macro Philippe Mathieu-Daudé
2024-10-15 0:09 ` Richard Henderson
2024-10-15 14:40 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).