From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA32C43603 for ; Mon, 9 Dec 2019 15:15:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28BE82077B for ; Mon, 9 Dec 2019 15:15:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wb00X+YM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28BE82077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieKkd-0001BX-1d for qemu-devel@archiver.kernel.org; Mon, 09 Dec 2019 10:15:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47236) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieKY0-0003XT-Us for qemu-devel@nongnu.org; Mon, 09 Dec 2019 10:02:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieKXz-0001UB-AJ for qemu-devel@nongnu.org; Mon, 09 Dec 2019 10:02:04 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:53788) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieKXz-0001RI-17 for qemu-devel@nongnu.org; Mon, 09 Dec 2019 10:02:03 -0500 Received: by mail-wm1-x343.google.com with SMTP id n9so15329102wmd.3 for ; Mon, 09 Dec 2019 07:02:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZyE5O5JAEITvx4NuqnX21tFQPYz9WQOu6fuX5qbaGbg=; b=Wb00X+YMD1KYN/d0ocuLnKKN901g3qFCF6qwRai4I8cwijtUQPh111Sy9Fx8RxGU0I O5CDDGZppZb9q/IYe3wHU64yI9yqtNlYaIdJ5vDb0Mi80BJ5ZEuylNtVffu4TqQ+1KjO WzOY71f+IATfeB4X1HI1LjeAkkZfVlVPUiGsv87pLy5HAlsiCKWeKcT3vjLpk1VIT+r+ Dvi7UN+qPjIyBrN1GaARlt20xLudW6C87v7So6b7kfBv0yW5Db+a9QGsCUc3Bsp+ivmw BZp+LiMeZdozkZ0OY2ZkOnq+BVUjAP6WTzxVe9IprNkjvQtgBo4iE8scJK84PYIrrr9Z x07A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZyE5O5JAEITvx4NuqnX21tFQPYz9WQOu6fuX5qbaGbg=; b=VT13wIAv8bgFd+rOZbeJRs/NtBjwKq+QALEgJJ/O2TRFiORxOQ5MfmQZhzKbtBomPX JiWXGC9TbiLgWnI0wwlUS8SAgU//1+my2voUvx/eim860P69E37PNFT8d8A76hoQjDKh ikqDfzmLK5A06xcWQoNcNkbAjNB4NcPmO2qs7FV6qwarJMhEpyAomXFmA5Bdh6LBw23C WUnp3cDTaSHOf+tLgmdY+bTsnzwlfyC88731Edl55wIlNUy+yftRG11SDMlrjb4cZ34c 3AKoySLlGHSZ2kv/4lAxx1xbby72CfefmKD/530EqZbIuqB1oVzCnEpa3D4zwy382Dq1 p8Bw== X-Gm-Message-State: APjAAAU9iOnznsHsbArURIFvgwqBwdPmZ8tqut7dtR4VqbZGW5dZpZca ERRVEBPDM9l9Yvdbdozci7Ciptf1 X-Google-Smtp-Source: APXvYqyP2EARTK8tctjseidflj3T0tn4xfwh4KRnY80EQy0LkgPyuzEfpbYIIU//azfBmM+2IObTiw== X-Received: by 2002:a1c:6255:: with SMTP id w82mr26596787wmb.20.1575903721806; Mon, 09 Dec 2019 07:02:01 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id g9sm27219371wro.67.2019.12.09.07.02.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Dec 2019 07:02:01 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH v2 13/18] tcg: convert "-accel threads" to a QOM property Date: Mon, 9 Dec 2019 16:01:40 +0100 Message-Id: <1575903705-12925-14-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1575903705-12925-1-git-send-email-pbonzini@redhat.com> References: <1575903705-12925-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, elmarco@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Replace the ad-hoc qemu_tcg_configure with generic code invoking QOM property getters and setters. More properties (and thus more valid -accel suboptions) will be added in the next patches, which will move accelerator-related "-machine" options to accelerators. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- accel/tcg/tcg-all.c | 50 ++++++++++++++++++++++++++++++++++++-------------- include/sysemu/cpus.h | 2 -- vl.c | 32 +++++++++++++++++--------------- 3 files changed, 53 insertions(+), 31 deletions(-) diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index 78a0ab5..7829f02 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -34,7 +34,17 @@ #include "include/qapi/error.h" #include "include/qemu/error-report.h" #include "include/hw/boards.h" -#include "qemu/option.h" + +typedef struct TCGState { + AccelState parent_obj; + + bool mttcg_enabled; +} TCGState; + +#define TYPE_TCG_ACCEL ACCEL_CLASS_NAME("tcg") + +#define TCG_STATE(obj) \ + OBJECT_CHECK(TCGState, (obj), TYPE_TCG_ACCEL) unsigned long tcg_tb_size; @@ -109,23 +119,31 @@ static void tcg_accel_instance_init(Object *obj) { TCGState *s = TCG_STATE(obj); - mttcg_enabled = default_mttcg_enabled(); + s->mttcg_enabled = default_mttcg_enabled(); } static int tcg_init(MachineState *ms) { + TCGState *s = TCG_STATE(current_machine->accelerator); + tcg_exec_init(tcg_tb_size * 1024 * 1024); cpu_interrupt_handler = tcg_handle_interrupt; + mttcg_enabled = s->mttcg_enabled; return 0; } -void qemu_tcg_configure(QemuOpts *opts, Error **errp) +static char *tcg_get_thread(Object *obj, Error **errp) { - const char *t = qemu_opt_get(opts, "thread"); - if (!t) { - return; - } - if (strcmp(t, "multi") == 0) { + TCGState *s = TCG_STATE(obj); + + return g_strdup(s->mttcg_enabled ? "multi" : "single"); +} + +static void tcg_set_thread(Object *obj, const char *value, Error **errp) +{ + TCGState *s = TCG_STATE(obj); + + if (strcmp(value, "multi") == 0) { if (TCG_OVERSIZED_GUEST) { error_setg(errp, "No MTTCG when guest word size > hosts"); } else if (use_icount) { @@ -140,12 +158,12 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp) "than the host provides"); error_printf("This may cause strange/hard to debug errors\n"); } - mttcg_enabled = true; + s->mttcg_enabled = true; } - } else if (strcmp(t, "single") == 0) { - mttcg_enabled = false; + } else if (strcmp(value, "single") == 0) { + s->mttcg_enabled = false; } else { - error_setg(errp, "Invalid 'thread' setting %s", t); + error_setg(errp, "Invalid 'thread' setting %s", value); } } @@ -155,15 +173,19 @@ static void tcg_accel_class_init(ObjectClass *oc, void *data) ac->name = "tcg"; ac->init_machine = tcg_init; ac->allowed = &tcg_allowed; -} -#define TYPE_TCG_ACCEL ACCEL_CLASS_NAME("tcg") + object_class_property_add_str(oc, "thread", + tcg_get_thread, + tcg_set_thread, + NULL); +} static const TypeInfo tcg_accel_type = { .name = TYPE_TCG_ACCEL, .parent = TYPE_ACCEL, .instance_init = tcg_accel_instance_init, .class_init = tcg_accel_class_init, + .instance_size = sizeof(TCGState), }; static void register_accel_types(void) diff --git a/include/sysemu/cpus.h b/include/sysemu/cpus.h index 32c05f2..3c1da6a 100644 --- a/include/sysemu/cpus.h +++ b/include/sysemu/cpus.h @@ -40,6 +40,4 @@ extern int smp_threads; void list_cpus(const char *optarg); -void qemu_tcg_configure(QemuOpts *opts, Error **errp); - #endif diff --git a/vl.c b/vl.c index 078ab7a..b6c23d1 100644 --- a/vl.c +++ b/vl.c @@ -295,17 +295,12 @@ static QemuOptsList qemu_accel_opts = { .implied_opt_name = "accel", .head = QTAILQ_HEAD_INITIALIZER(qemu_accel_opts.head), .desc = { - { - .name = "accel", - .type = QEMU_OPT_STRING, - .help = "Select the type of accelerator", - }, - { - .name = "thread", - .type = QEMU_OPT_STRING, - .help = "Enable/disable multi-threaded TCG", - }, - { /* end of list */ } + /* + * no elements => accept any + * sanity checking will happen later + * when setting accelerator properties + */ + { } }, }; @@ -2836,6 +2831,13 @@ static int do_configure_icount(void *opaque, QemuOpts *opts, Error **errp) return 0; } +static int accelerator_set_property(void *opaque, + const char *name, const char *value, + Error **errp) +{ + return object_parse_property_opt(opaque, name, value, "accel", errp); +} + static int do_configure_accelerator(void *opaque, QemuOpts *opts, Error **errp) { bool *p_init_failed = opaque; @@ -2850,6 +2852,10 @@ static int do_configure_accelerator(void *opaque, QemuOpts *opts, Error **errp) return 0; } accel = ACCEL(object_new_with_class(OBJECT_CLASS(ac))); + qemu_opt_foreach(opts, accelerator_set_property, + accel, + &error_fatal); + ret = accel_init_machine(accel, current_machine); if (ret < 0) { *p_init_failed = true; @@ -2857,10 +2863,6 @@ static int do_configure_accelerator(void *opaque, QemuOpts *opts, Error **errp) acc, strerror(-ret)); return 0; } - - if (tcg_enabled()) { - qemu_tcg_configure(opts, &error_fatal); - } return 1; } -- 1.8.3.1