* [PATCH] docker: gtester is no longer used
@ 2019-12-18 1:30 Paolo Bonzini
2019-12-18 6:32 ` Thomas Huth
2019-12-18 19:47 ` Alex Bennée
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2019-12-18 1:30 UTC (permalink / raw)
To: qemu-devel; +Cc: alex.bennee
We are using tap-driver.pl, do not require anymore gtester to be installed
to run the testsuite in docker-based tests.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/docker/common.rc | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index 512202b..02cd67a 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -53,12 +53,7 @@ check_qemu()
INVOCATION="$@"
fi
- if command -v gtester > /dev/null 2>&1 && \
- gtester --version > /dev/null 2>&1; then
- make $MAKEFLAGS $INVOCATION
- else
- echo "No working gtester, skipping make $INVOCATION"
- fi
+ make $MAKEFLAGS $INVOCATION
}
test_fail()
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] docker: gtester is no longer used
2019-12-18 1:30 [PATCH] docker: gtester is no longer used Paolo Bonzini
@ 2019-12-18 6:32 ` Thomas Huth
2019-12-18 19:47 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2019-12-18 6:32 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: QEMU Trivial, alex.bennee
On 18/12/2019 02.30, Paolo Bonzini wrote:
> We are using tap-driver.pl, do not require anymore gtester to be installed
> to run the testsuite in docker-based tests.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/docker/common.rc | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 512202b..02cd67a 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -53,12 +53,7 @@ check_qemu()
> INVOCATION="$@"
> fi
>
> - if command -v gtester > /dev/null 2>&1 && \
> - gtester --version > /dev/null 2>&1; then
> - make $MAKEFLAGS $INVOCATION
> - else
> - echo "No working gtester, skipping make $INVOCATION"
> - fi
> + make $MAKEFLAGS $INVOCATION
> }
>
> test_fail()
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docker: gtester is no longer used
2019-12-18 1:30 [PATCH] docker: gtester is no longer used Paolo Bonzini
2019-12-18 6:32 ` Thomas Huth
@ 2019-12-18 19:47 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2019-12-18 19:47 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> We are using tap-driver.pl, do not require anymore gtester to be installed
> to run the testsuite in docker-based tests.
Queued to pullreq/testing-logging-misc, thanks.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/docker/common.rc | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 512202b..02cd67a 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -53,12 +53,7 @@ check_qemu()
> INVOCATION="$@"
> fi
>
> - if command -v gtester > /dev/null 2>&1 && \
> - gtester --version > /dev/null 2>&1; then
> - make $MAKEFLAGS $INVOCATION
> - else
> - echo "No working gtester, skipping make $INVOCATION"
> - fi
> + make $MAKEFLAGS $INVOCATION
> }
>
> test_fail()
--
Alex Bennée
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-18 19:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-18 1:30 [PATCH] docker: gtester is no longer used Paolo Bonzini
2019-12-18 6:32 ` Thomas Huth
2019-12-18 19:47 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).